Attempt to set parameters 3 times by default#1037
Merged
1Blademaster merged 6 commits intomainfrom Mar 5, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates parameter-setting behavior to retry (up to the default 3 attempts) when a PARAM_VALUE ack is received but does not confirm the requested value, and removes a magic-number MAVLink param type in the flight modes controller.
Changes:
- Update
ParamsController.setParam()to track remaining retries explicitly and re-attempt setting when the acked value mismatches. - Improve log messaging around retries/attempt counts for parameter setting failures.
- Replace hard-coded
param_type = 2withmavutil.mavlink.MAV_PARAM_TYPE_INT8in flight mode parameter updates.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| radio/app/controllers/paramsController.py | Adjusts retry loop/ack-handling so value mismatches trigger another attempt; updates logging. |
| radio/app/controllers/flightModesController.py | Replaces a magic-number MAVLink param type with a named constant for clarity. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
Will keep this PR open for a while just so I can ensure that the tests pass repeatedly... |
Member
Author
|
Looking at the AP firmware, it's a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.