security: avoid logging Droid settings contents#88
Open
EffortlessSteven wants to merge 1 commit intoFactory-AI:devfrom
Open
security: avoid logging Droid settings contents#88EffortlessSteven wants to merge 1 commit intoFactory-AI:devfrom
EffortlessSteven wants to merge 1 commit intoFactory-AI:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
setupDroidSettingsprinted the contents of an existing settings file.Droid settings may contain provider credentials, custom model configuration, MCP env values, or token-shaped runtime fields. Logging the full settings object creates avoidable exposure in CI logs.
Change
[object Object].Review map
base-action/src/setup-droid-settings.tsbase-action/test/setup-droid-settings.test.tsBehavior
Before:
After:
Settings merge behavior is unchanged.
Validation
Non-goals
Contribution license
This repository does not currently include a FOSS license or contributor license agreement.
For this pull request, I expressly grant Factory AI and its affiliates a perpetual, worldwide, royalty-free, irrevocable license to use, copy, modify, publish, distribute, sublicense, and relicense these contributions, including as part of this repository or any related Factory AI product or service.