debug: add redacted Droid debug artifacts#87
Open
EffortlessSteven wants to merge 2 commits intoFactory-AI:devfrom
Open
debug: add redacted Droid debug artifacts#87EffortlessSteven wants to merge 2 commits intoFactory-AI:devfrom
EffortlessSteven wants to merge 2 commits intoFactory-AI:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The preceding raw-artifact removal PR removes default runtime debug artifacts. That closes the unsafe default, but it also removes a useful debugging path.
The replacement should not upload broad runtime directories with a blocklist of exclusions. It should build a new allowlisted bundle and redact selected files before upload.
Change
debug_artifactswith supported modes:noneredacteddebug_artifacts: none.debug_artifact_retention_days, default1.${{ runner.temp }}/droid-debug-artifacts/**.actions/upload-artifactSHA-pinned.Review map
action.ymlaction.ymlsrc/debug-artifacts/collect.tssrc/debug-artifacts/redact.tssrc/entrypoints/prepare-debug-artifacts.tstest/debug-artifacts/*,test/action-yml.test.tsREADME.mdBehavior
Default:
No debug bundle is prepared or uploaded.
Opt-in:
The action creates and uploads only:
Raw runtime state is not uploaded.
Artifact model
The redacted bundle is built as a new directory. It does not copy
$HOME/.factorywholesale.Included files are allowlisted and written with
.redactedsuffixes. Unknown runtime files are skipped.Dependency
This PR is stacked on #86.
Until #86 lands, GitHub may show the raw-artifact removal diff in this PR as well. The intended review surface for this PR is the redacted debug artifact mode added after that removal.
This PR assumes the raw
.factory/**anddroid-prompts/**upload path has already been removed.Related issue
Related:
Factory-AI/droid-action#20, because this PR adds a nestedactions/upload-artifactusage and keeps it SHA-pinned.This does not resolve
Factory-AI/droid-action#20unless all nested action references are audited.Validation
Non-goals
Contribution license
This repository does not currently include a FOSS license or contributor license agreement.
For this pull request, I expressly grant Factory AI and its affiliates a perpetual, worldwide, royalty-free, irrevocable license to use, copy, modify, publish, distribute, sublicense, and relicense these contributions, including as part of this repository or any related Factory AI product or service.