Skip to content

.github/workflows: Migrate workflows to Blacksmith runners#6443

Closed
blacksmith-sh[bot] wants to merge 1 commit intomainfrom
blacksmith-migration-70313a9
Closed

.github/workflows: Migrate workflows to Blacksmith runners#6443
blacksmith-sh[bot] wants to merge 1 commit intomainfrom
blacksmith-migration-70313a9

Conversation

@blacksmith-sh
Copy link
Copy Markdown

@blacksmith-sh blacksmith-sh Bot commented Mar 20, 2026

To whomever may be reviewing this PR,

Blacksmith is the fastest way to run your GitHub Actions.

What does this PR change?

This PR has been automatically generated by a team member in your GitHub organization using Blacksmith's Migration Wizard, or MigWiz for short. This PR changes the following:

  1. Your selected workflows will now run on Blacksmith's 2x faster hardware (e.g., runs-on: blacksmith-4vcpu-ubuntu-2204). Learn more about the different instances available to choose from.
  2. Your jobs running on Blacksmith will now have all official GitHub and popular third-party cache actions automatically interact with our 4x faster, colocated cache. Learn more about Blacksmith's actions cache.
  3. Your GitHub Actions will now actually be observable. Learn more about Blacksmith's logging and other observability features.
  4. Your Docker builds will now automatically share their Docker layer cache, resulting in up to 40x faster builds. Learn more about Blacksmith's Docker layer caching.

FAQ

  • Is this free? The first 3,000 minutes per month are free.
  • Who uses Blacksmith? Clerk, Ashby, VEED, and 600+ others.
  • What's the catch? There is none. Merge this thing already.

@blacksmith-sh blacksmith-sh Bot requested a review from a team as a code owner March 20, 2026 18:32
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Mar 20, 2026

Greptile Summary

This PR migrates the benchmark-codspeed job in .github/workflows/pr-test-suite.yml from the Buildjet runner (buildjet-8vcpu-ubuntu-2204) to the Blacksmith runner (blacksmith-8vcpu-ubuntu-2204) for faster CI execution.

  • The change is a single-line runs-on substitution in the benchmark-codspeed job.
  • Issue: The Swatinem/rust-cache@v2 step's cache-provider: buildjet (line 1240) was not updated to match the new runner. This creates a provider mismatch — the cache action will attempt to communicate with Buildjet's cache backend from a Blacksmith-hosted runner, which will result in cache misses at best and job failures at worst.
  • The rest of the workflow's jobs (which use standard GitHub-hosted runners) are unaffected by this change.

Confidence Score: 3/5

  • The PR is mostly safe but has a cache provider mismatch that will break Rust caching for the benchmark job.
  • The runner substitution itself is straightforward, but the incomplete migration leaves cache-provider: buildjet pointing at Buildjet's backend from a Blacksmith runner, which will cause the Rust cache to be non-functional for this job. This is a minor correctness issue that degrades CI performance rather than breaking correctness of the benchmark results themselves.
  • pr-test-suite.yml — specifically the Swatinem/rust-cache step in the benchmark-codspeed job needs its cache-provider updated.

Important Files Changed

Filename Overview
.github/workflows/pr-test-suite.yml Migrates the benchmark-codspeed job runner from buildjet-8vcpu-ubuntu-2204 to blacksmith-8vcpu-ubuntu-2204, but leaves cache-provider: buildjet in the Swatinem/rust-cache step unchanged, creating a mismatch between the runner and its cache backend.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[PR triggered] --> B[skipcheck job]
    B --> C{skip == 'false'?}
    C -- No --> D[Skip benchmark]
    C -- Yes --> E[benchmark-codspeed job\nruns-on: blacksmith-8vcpu-ubuntu-2204]
    E --> F[Checkout + restore-mtime]
    F --> G[moonrepo/setup-rust]
    G --> H[Swatinem/rust-cache\ncache-provider: buildjet ⚠️\nMismatch with Blacksmith runner]
    H --> I[Setup Python / uv]
    I --> J[Install dependencies]
    J --> K[Build Rust Library via maturin]
    K --> L[Restore TPC-H data cache\nactions/cache v5]
    L --> M[CodSpeedHQ/action\nRun benchmarks in simulation mode]
    M --> N{Success?}
    N -- Failure + main branch --> O[Send Slack notification]
    N -- Success --> P[Done]

    style H fill:#ff9999,stroke:#cc0000
Loading

Comments Outside Diff (1)

  1. .github/workflows/pr-test-suite.yml, line 1240 (link)

    P2 Stale cache-provider after runner migration

    The runs-on was changed to blacksmith-8vcpu-ubuntu-2204, but the cache-provider: buildjet on this line was not updated. Swatinem/rust-cache@v2 will attempt to use Buildjet's cache backend from a Blacksmith runner, which will result in cache misses at best or outright failures at worst — completely negating the caching benefit.

    This should either be removed (to fall back to the standard GitHub Actions cache) or updated to the appropriate Blacksmith-compatible cache provider.

Last reviewed commit: "Migrate workflows to..."

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.83%. Comparing base (6448008) to head (db12c5e).
⚠️ Report is 41 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6443      +/-   ##
==========================================
- Coverage   74.85%   74.83%   -0.03%     
==========================================
  Files        1024     1024              
  Lines      137716   137697      -19     
==========================================
- Hits       103083   103040      -43     
- Misses      34633    34657      +24     

see 13 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rchowell
Copy link
Copy Markdown
Contributor

Closed in favor of, #6416

@rchowell rchowell closed this Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant