Conversation
Update all S3 bucket names, CloudFront distribution ID, and domain to point to the new daft-oss AWS account resources. - github-actions-artifacts-bucket -> daft-oss-github-actions-artifacts - daft-public-data -> daft-oss-public-data - daft-public-datasets -> daft-oss-public-datasets - CloudFront: E3H8WN738AJ1D4 -> E1QUPAB4XXQ64R - CloudFront domain: d1p3klp2t5517h.cloudfront.net -> ds0gqyebztuyf.cloudfront.net
Greptile SummaryThis PR migrates all references to a new dedicated OSS AWS account, updating three S3 buckets ( Key observations:
Confidence Score: 5/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[GitHub Actions Workflows] -->|publish artifacts| B[S3: daft-oss-github-actions-artifacts]
B -->|invalidate & serve| C[CloudFront: E1QUPAB4XXQ64R\nds0gqyebztuyf.cloudfront.net]
C -->|pip install --extra-index-url| D[End Users]
E[Tests / Benchmarks / Docs / Tutorials] -->|anonymous read| F[S3: daft-oss-public-data]
E -->|anonymous read| G[S3: daft-oss-public-datasets]
subgraph Old OSS Account
H[github-actions-artifacts-bucket]
I[daft-public-data]
J[daft-public-datasets]
K[CloudFront: E3H8WN738AJ1D4\nd1p3klp2t5517h.cloudfront.net]
end
subgraph New Dedicated OSS Account
B
F
G
C
end
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6442 +/- ##
==========================================
- Coverage 74.85% 74.83% -0.02%
==========================================
Files 1024 1024
Lines 137716 137697 -19
==========================================
- Hits 103083 103042 -41
- Misses 34633 34655 +22
🚀 New features to boost your workflow:
|
|
@jeevb are you able to confirm all the gh actions ran with these update refs? I will merge this ASAP |
|
@rchowell Not yet. Was planning on testing after merge since it requires a secret change at the repo level anyway. If there is someone else around, I can iterate on fixes quickly. Biggest risk is missing permissions, which we can fix at infra level. |
## Changes Made Update to use new dedicated OSS AWS account: - S3 buckets for GitHub artifacts, and public datasets - CloudFront distribution Requires: - Update `ACTIONS_AWS_IAM_ROLE` GitHub secret ## Related Issues <!-- Link to related GitHub issues, e.g., "Closes Eventual-Inc#123" -->
Changes Made
Update to use new dedicated OSS AWS account:
Requires:
ACTIONS_AWS_IAM_ROLEGitHub secretRelated Issues