connectd: remove my DNS seed#8968
Open
darosior wants to merge 1 commit intoElementsProject:masterfrom
Open
Conversation
Contributor
Author
|
Can this get tagged for v26.04? |
Collaborator
|
Probably you have just to fix the pre build check with BTW IIRC the seed is not being used anymore, but it's worth cleaning up |
sangbida
added
the
26.04 RC
Member
It's a sad day, godspeed @darosior 🤗 |
cdecker
approved these changes
Mar 28, 2026
I do not maintain it anymore.
sangbida
force-pushed
the
2603_remove_darosior_seed
branch
from
5a50574 to
d9ad271
Compare
Contributor
|
Actually, we dropped use of DNS seeds altogether: they were generally unreliable. This is a remnant, when a proxy is used. I shall excise the code instead. |
rustyrussell
added a commit
to rustyrussell/lightning
that referenced
this pull request
Mar 30, 2026
For 25.05 (0a94f3b) we removed DNS lookups, but we left them for the corner case where a proxy is used. darosior points out that his is no longer functional, which brought my attention to this vestigial corner case. Changelog-None: we said we'd removed them earlier! Reported-by: darosior Closes: ElementsProject#8968 Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
added a commit
to rustyrussell/lightning
that referenced
this pull request
Mar 31, 2026
For 25.05 (0a94f3b) we removed DNS lookups, but we left them for the corner case where a proxy is used. darosior points out that his is no longer functional, which brought my attention to this vestigial corner case. Changelog-None: we said we'd removed them earlier! Reported-by: darosior Closes: ElementsProject#8968 Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I do not maintain this DNS seed anymore.
Changelog-None