Open
Conversation
redo rrtmgp reorganization; fix loop typo
modified: src/physics/carma/cam/carma_intr.F90
modified: src/physics/carma/models/trop_strat_soa1/carma_model_mod.F90 modified: src/physics/carma/models/trop_strat_soa5/carma_model_mod.F90
modified: cime_config/testdefs/testlist_cam.xml
peverwhee
approved these changes
Apr 14, 2026
Collaborator
peverwhee
left a comment
peverwhee
left a comment
There was a problem hiding this comment.
one tiny thing, but not enough to hold up my approval.
| real(r8) :: vol(istart:istop) ! aerosol volume mixing ratio | ||
| integer :: i, l | ||
| real(r8) :: vol(ncol,nlev) ! aerosol volume mixing ratio | ||
| integer :: i, k, l |
Collaborator
There was a problem hiding this comment.
looks like you no longer need i or k in this routine
modified: src/chemistry/aerosol/aerosol_state_mod.F90
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables the use of CARMA with RRTMGP / cam7 physics.
Closes #1430
Also includes some changes to improve performance of CARMA.