Various identified issues#65
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent runtime null-reference failures by hardening generated polyfill interceptors (notably around params IExpressionTreeTransformer[] transformers) and adds targeted regression tests to cover previously identified edge cases.
Changes:
- Add null-argument and null-element validation for
transformersin generatedExpressionPolyfill.Create(..., params IExpressionTreeTransformer[] transformers)interceptors. - Add/extend unit, generator, and integration tests for expansion/polymorphism, polyfill edge cases (switch patterns, list patterns), and generator diagnostics behavior.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/ExpressiveSharp.Tests/Extensions/ExpressionPolyfillTests.cs | Adds a regression test ensuring null transformer arguments throw ArgumentNullException. |
| tests/ExpressiveSharp.IntegrationTests/Tests/ExpansionEdgeCasesTests.cs | Adds integration coverage for polymorphic dispatch and additional polyfill edge cases. |
| tests/ExpressiveSharp.Generator.Tests/PolyfillInterceptorGenerator/JoinTests.cs | Adds a generator test that compiles the generated interceptor for GroupJoin with an anonymous result selector. |
| tests/ExpressiveSharp.Generator.Tests/ExpressiveGenerator/ListPatternTests.cs | Adds a diagnostic-regression test for list patterns on arrays. |
| tests/ExpressiveSharp.Generator.Tests/ExpressiveGenerator/IndexRangeTests.cs | Adds a diagnostic-regression test for string range slicing. |
| src/ExpressiveSharp.Generator/PolyfillInterceptorGenerator.cs | Emits null checks for transformers and its elements to avoid runtime NREs during transformer application. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+174
to
+178
|
|
||
| var errors = outputCompilation.GetDiagnostics() | ||
| .Where(d => d.Severity == DiagnosticSeverity.Error) | ||
| .ToList(); | ||
|
|
| } | ||
| """); | ||
| var result = RunExpressiveGenerator(compilation); | ||
|
|
| } | ||
| """); | ||
| var result = RunExpressiveGenerator(compilation); | ||
|
|
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #64 amongst other things