fix: include VMM QEMU options in MR verification#677
Closed
Leechael wants to merge 9 commits into
Closed
Conversation
344c987 to
d1c8687
Compare
d1c8687 to
fa4126b
Compare
Collaborator
Author
|
Closing in favor of #678 which is the actual root-cause fix (OVMF edk2-stable202505 event-log layout). All changes in this PR turned out to be either dead code (SMBIOS / virtfs_security_model / qgs into Machine / legacy SMBIOS fallback don't enter the RTMR0 formula) or regression sources (9p security_model=mapped→none broke pre-existing CVMs). See the diagnose tool extracted into #679. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This aligns KMS/verifier MR calculation with the QEMU shape used by the VMM.
Changes:
dstack_types::VmConfigwithqgs_port, SMBIOS product fields, andvirtfs_security_model..sys-config.json/vm_config.dstack-mr.dstack-mrinclude-smbiosand configurable 9psecurity_modelin its ACPI-table QEMU invocation.security_model=mappedtosecurity_model=none.passthrough-dump-acpi @ d98440811192c08eafc07c7af110593c6b3758ffasdstack-acpi-tables-8.2.2dstack-qemu-9.2.1 @ dbcec07c0854bf873d346a09e87e4c993ccf2633asdstack-acpi-tables-9.2.1vm_config.qemu_version:< 9.0.0->dstack-acpi-tables-8.2.2>= 9.0.0->dstack-acpi-tables-9.2.1-L:/usr/local/share/qemu-8.2.2/usr/local/share/qemu-9.2.1libpixman-1-0.Context
Runtime VMM hosts can use QEMU 8.2.2 while KMS/verifier had only the 9.2.1-derived
dstack-acpi-tables. That makes expected MR calculation depend on the wrong ACPI-dump QEMU for 8.x hosts.This PR keeps
qgs_port = 4050enabled. Disabling QGS is not a valid fix because it changes the runtime VM behavior.OS image
0.5.10updates OVMF toedk2-stable202505; with the newer TDVF/OVMF, the existing mismatch between real VMM QEMU and verifier-side ACPI-dump QEMU can surface as MRTD/RTMR0 mismatch during KMS onboarding.Verification
cargo test -p dstack-mr acpi::testscargo check -p dstack-mr -p dstack-verifier -p dstack-kmsgit diff --checkdocker buildx build --call=targets -f verifier/builder/Dockerfile --build-context build-shared=build/shared verifierdocker buildx build --call=targets -f kms/dstack-app/builder/Dockerfile --build-context build-shared=build/shared kms/dstack-app/builderNote:
cargo check -p dstack-vmmon macOS still hits the existing Linux-onlynix::fcntl::splicegate inport-forward. Cross-checkingdstack-vmmforx86_64-unknown-linux-gnuwas blocked locally by missingx86_64-linux-gnu-gccforring.