fix: bump vulnerable transitive dependencies via resolutions#595
fix: bump vulnerable transitive dependencies via resolutions#595jonathannorris merged 3 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses Dependabot-reported vulnerabilities by forcing patched versions of several vulnerable transitive dependencies using Yarn resolutions, and updating the lockfile accordingly.
Changes:
- Added Yarn
resolutionsoverrides forbrace-expansion,picomatch,flatted, andundicito ensure patched versions are selected. - Updated
yarn.lockto reflect the resolved patched versions and checksums.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
package.json |
Adds resolutions entries to force patched transitive dependency versions. |
yarn.lock |
Updates locked versions/checksums for the affected transitive dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 7 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "flatted@^3.2.9": "^3.4.2", | ||
| "undici@^7.10.0": "^7.24.6", | ||
| "lodash@^4.17.15": "^4.18.0", | ||
| "lodash@^4.17.21": "^4.18.0" |
There was a problem hiding this comment.
The PR description/table lists fixes for brace-expansion, picomatch, flatted, and undici, but this change also introduces new lodash resolutions (and the lockfile moves lodash to 4.18.1). Please either document lodash as part of the security bump (including the versions/alerts being addressed) or drop the lodash resolutions if they’re unintended.
| "packageManager": "yarn@4.9.2", | ||
| "resolutions": { | ||
| "diff@^4.0.1": "^4.0.4" | ||
| "diff@^4.0.1": "^4.0.4", | ||
| "lodash@^4.17.21": "^4.18.0" | ||
| } |
There was a problem hiding this comment.
This adds a lodash resolution, but lodash isn’t mentioned in the PR summary/table of patched dependencies. Please document why lodash is being forced here (which alert/vulnerability it addresses) or remove the resolution if it’s not required.
| "packageManager": "yarn@4.9.2", | ||
| "resolutions": { | ||
| "diff@^4.0.1": "^4.0.4", | ||
| "qs@^6.5.2": "^6.14.2" | ||
| "qs@^6.5.2": "^6.14.2", | ||
| "lodash@^4.17.21": "^4.18.0" | ||
| } |
There was a problem hiding this comment.
This adds a lodash resolution, but lodash isn’t mentioned in the PR summary/table of patched dependencies. Please document why lodash is being forced here (which alert/vulnerability it addresses) or remove the resolution if it’s not required.
Summary
resolutionsentries to force patched versions of vulnerable transitive dependenciesbrace-expansion,picomatch,flatted, andundicibrace-expansionbrace-expansionpicomatchpicomatchflattedundici