Skip to content

chore: fix dependabot alerts #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jonathannorris wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore: fix dependabot alerts #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9a7164d
chore: fix dependabot alerts by upgrading semantic-release and adding…
jonathannorris Mar 31, 2026
7a8c5f4
chore: address PR feedback - use caret overrides and bump CI to Node 20
jonathannorris Mar 31, 2026
6e39ce4
chore: add .npmrc with legacy-peer-deps to fix CI
jonathannorris Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/benchmark.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v1
with:
node-version: 15
node-version: 20
Comment on lines 13 to +16
Copy link

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actions/setup-node@v1 is deprecated and runs on a retired Node runtime. With this workflow moving to Node 20, upgrade to the current major of setup-node (and consider bumping checkout as well) to avoid the action being disabled and breaking the benchmark workflow.

Copilot uses AI. Check for mistakes.
- run: npm ci
- run: npm run asbuild
# Run benchmark with `go test -bench` and stores the output to a file
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,14 @@ on:
jobs:
release:
name: Release
runs-on: ubuntu-18.04
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v1
- name: Setup Node.js
uses: actions/setup-node@v1
Comment on lines 16 to 18
Copy link

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow still uses deprecated actions/checkout@v1 and actions/setup-node@v1. These older JS actions run on retired Node runtimes and can start failing as GitHub disables them; please upgrade to the current major versions (e.g., checkout v4 / setup-node v4) while updating the runner/Node version.

Suggested change
uses: actions/checkout@v1
- name: Setup Node.js
uses: actions/setup-node@v1
uses: actions/checkout@v4
- name: Setup Node.js
uses: actions/setup-node@v4

Copilot uses AI. Check for mistakes.
with:
node-version: 15
node-version: 20
- name: Install dependencies
run: npm ci
- name: Run tests
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:

strategy:
matrix:
node-version: [15.x]
node-version: [20.x]
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/

Comment on lines 16 to 20
Copy link

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this job is now targeting Node 20, please also update the workflow’s Node-related actions (notably actions/setup-node@v1, and ideally actions/checkout@v2) to their current majors. The v1/v2 action generations run on retired Node runtimes and are at risk of being disabled by GitHub, causing CI failures.

Copilot uses AI. Check for mistakes.
steps:
Expand Down
1 change: 1 addition & 0 deletions .npmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
legacy-peer-deps=true
Copy link

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Committing legacy-peer-deps=true disables npm's peer dependency resolution/validation for all installs, which can mask incompatible dependency graphs and make future upgrades harder. Prefer fixing the underlying peer dependency conflicts, or scope this to CI only (e.g., use npm ci --legacy-peer-deps in workflows) and document why it’s needed if it must remain.

Suggested change
legacy-peer-deps=true

Copilot uses AI. Check for mistakes.
Loading
Loading