java(dsm): fix flaky Test_Dsm_Manual_Checkpoint_Inter_Process by waiting for DSM data#6579
Draft
robcarlan-datadog wants to merge 2 commits intomainfrom
Draft
java(dsm): fix flaky Test_Dsm_Manual_Checkpoint_Inter_Process by waiting for DSM data#6579robcarlan-datadog wants to merge 2 commits intomainfrom
robcarlan-datadog wants to merge 2 commits intomainfrom
Conversation
…ing for DSM data The Java tracer does not flush DSM stats immediately (unlike Python which calls flush_dsm_checkpoints()), relying instead on periodic flush. The assert_checkpoint_presence helper did a single pass through collected data with no retry, so it would miss checkpoints that hadn't been flushed yet. Add wait_for() to assert_checkpoint_presence so it waits up to 30s for matching DSM data to arrive before asserting. This uses the existing event-driven wait mechanism in ProxyBasedInterfaceValidator. Remove the flaky marking from manifests/java.yml (DSMON-1257). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
|
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
✨ Fix all issues with BitsAI or with Cursor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test_Dsm_Manual_Checkpoint_Inter_Processfor Java spring-boot (DSMON-1257)wait_for()toDsmHelper.assert_checkpoint_presenceso it waits up to 30s for matching DSM data before assertingmanifests/java.ymlRoot Cause
The Python Flask weblog explicitly calls
flush_dsm_checkpoints()after every manual checkpoint operation, forcing the tracer to send DSM stats to the agent immediately. The Java Spring Boot weblog has no equivalent flush — it relies on the Java tracer's periodic flush interval (~10s).assert_checkpoint_presencedid a single pass through collected agent data with no retry. When the Java tracer hadn't flushed yet, the correct consumer checkpoint wasn't in the agent data and the assertion failed.Fix
Use the existing
interfaces.agent.wait_for()event-driven mechanism (already used bywait_for_remote_config_request,wait_for_client_side_stats_payload, etc.) to wait for matching DSM data to arrive:Test plan
🤖 Generated with Claude Code