Skip to content

Fix semver#6576

Open
nccatoni wants to merge 14 commits intomainfrom
nccatoni/fix-semver
Open

Fix semver#6576
nccatoni wants to merge 14 commits intomainfrom
nccatoni/fix-semver

Conversation

@nccatoni
Copy link
Collaborator

Motivation

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions
Copy link
Contributor

CODEOWNERS have been resolved as:

tests/test_the_test/test_version.py                                     @DataDog/system-tests-core
utils/manifest/_internal/types.py                                       @DataDog/system-tests-core

@nccatoni nccatoni marked this pull request as ready for review March 24, 2026 09:41
@nccatoni nccatoni requested a review from a team as a code owner March 24, 2026 09:41
@nccatoni nccatoni requested a review from cbeauchesne March 24, 2026 09:43
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 037655441a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

nccatoni and others added 3 commits March 24, 2026 11:11
Co-authored-by: Charles de Beauchesne <charles.debeauchesne@datadoghq.com>
Co-authored-by: Charles de Beauchesne <charles.debeauchesne@datadoghq.com>
Co-authored-by: Charles de Beauchesne <charles.debeauchesne@datadoghq.com>
@nccatoni nccatoni marked this pull request as draft March 24, 2026 10:13
@datadog-prod-us1-6
Copy link

datadog-prod-us1-6 bot commented Mar 24, 2026

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 5b62756 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@nccatoni nccatoni marked this pull request as ready for review March 24, 2026 12:21
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a2cd300f54

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

# [CHANGED] Use subclauses directly instead of the library's prerelease split.
# The library separates prerelease/non-prerelease clauses and recombines them
# with extra bounds, which breaks direct prerelease comparison.
result |= AllOf(*subclauses)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve release match for exact prerelease declarations

Using result |= AllOf(*subclauses) drops the upstream parser’s prerelease/non-prerelease companion branch, which changes existing manifest behavior for exact prerelease pins: SemverRange("1.61.0-SNAPSHOT") stops matching 1.61.0 after this commit. Fresh evidence is in manifests/java.yml, which has inline 1.61.0-SNAPSHOT activations for telemetry tests; with this change, Java 1.61.0 is now treated as still missing_feature, so those tests can be skipped/incorrectly deactivated for the release build.

Useful? React with 👍 / 👎.

@nccatoni nccatoni requested a review from cbeauchesne March 24, 2026 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants