Add prepare-local-build.sh helper for local tracer testing#6499
Open
Add prepare-local-build.sh helper for local tracer testing#6499
Conversation
Contributor
|
|
|
✨ Fix all issues with BitsAI or with Cursor
|
f22786b to
a52cb1e
Compare
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
df0565d to
e21b86e
Compare
The volume-mount method fails because native C extensions (.so files) in the local checkout are built for a different Python version than the container's. The 'wheel' method (already the default) packages everything correctly. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
When auto-building Java JARs, resolve JAVA_HOME dynamically if the current value points to a missing directory. Supports macOS (/usr/libexec/java_home) and Linux (readlink on java binary). Fails with a clear message if no JDK is found at all. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7296675113
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Python s3 method takes a commit hash (not a directory) and pip doesn't need a path at all. Skip directory validation and default-path resolution for these methods so they work as documented. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Adds a .claude/skills/system-tests-local.md that teaches Claude Code how to use prepare-local-build.sh to set up binaries/ and run parametric tests against locally checked-out tracer repos. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Running system-tests against locally checked-out tracer repos requires knowing the per-language binaries/ conventions (JARs for Java, volume-mount pointer files for Node.js/Python, shallow clones for Go/Ruby/Rust/C++, tarballs for .NET/PHP). This script automates that setup.
Changes
Adds
utils/scripts/prepare-local-build.sh— a helper that handles the copy/clone/pointer-file step for each of the 9 supported languages.Features:
prepare-local-build.sh <lang> [path]— prepares binaries/ for the given language~/dd/dd-trace-<lang>when omittedprepare-local-build.sh --clean [lang]— removes binaries for one or all languagesprepare-local-build.sh --status— shows what's currently configured in binaries/prepare-local-build.sh --list— lists supported languages and methodsprepare-local-build.sh --rebuild— forces a fresh build even if artifacts exist--methodflag for languages with multiple options (e.g., Node.js local vs clone, Python wheel vs pip)Auto-build support (builds from source when artifacts are missing):
./gradlew :dd-java-agent:shadowJar :dd-trace-api:jar)scripts/ddtestwheel build (default method)tooling/bin/build-debug-artifactFollows the same shell style as
utils/scripts/watch.sh(set -euo pipefail, error/die helpers).Testing
Ran this locally to confirm that every language builds locally and runs against the parametric test:
test_distributed_headers_extract_datadog_D001Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P team🤖 Generated with Claude Code