Conversation
|
|
335d036 to
5e40f8a
Compare
|
✨ Fix all issues with BitsAI or with Cursor
|
5e40f8a to
53695b1
Compare
output_tokens n/a thus not set java uses base64 encoding format instead of float
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5d0c54e45c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0289d40807
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
utils/build/docker/java/openai_app/src/main/java/SingleFileServer.java
Outdated
Show resolved
Hide resolved
cbeauchesne
left a comment
There was a problem hiding this comment.
You need to add the new weblog in integration_frameworks_weblogs here : utils/scripts/ci_orchestrators/workflow_data.py
- Add openai-java@4.29.0 to integration_frameworks weblogs map - Enables CI to run integration tests for Java OpenAI SDK Rationale: New openai-java weblog was added to the repo and needs to be registered in CI orchestration This commit made by [/dd:git:commit:quick](https://github.com/DataDog/claude-marketplace/tree/main/dd/commands/git/commit/quick.md)
cbeauchesne
left a comment
There was a problem hiding this comment.
CI is failing. Feel free to ping me on slack if you need some help.
Two tests were expected to fail because the corresponding Java changes haven't been released yet. I changed the manifest so that they would be expected to fail until the next minor version. |
Motivation
Add support for system LLMObs tests for Java OpenAI SDK, covering chat completions, tool calls, responses API, and embedding interactions.
Add support for parametric LLMObs manual API tests for Java.
Changes
openai_app) built with Gradle/Javalin that implements OpenAI proxy endpoints fortesting
openai-java.Dockerfileto build and run the Java test app withdd-java-agentdd-apm-test-agentfrom v1.38.0 to v1.42.0/evp_proxy/v4endpoint inllmobs_requests(); add gzip decompression and MessagePackdecoding for Java tracer payloads
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present