[auto-jira][AGENTCFG-63] flare: extract buildFlareBaseURL to eliminate duplicated AddAgentVersionToDomain call

[rahulkaukuntla]

Summary

Both GetFlareEndpoint and SendTo in comp/core/flare/helpers/send_flare.go independently called configUtils.AddAgentVersionToDomain(url, "flare"). This PR extracts that into a private buildFlareBaseURL helper so both functions share the same implementation.

Before:

• GetFlareEndpoint (line 321): flareRoute, _ := configUtils.AddAgentVersionToDomain(configUtils.GetInfraEndpoint(cfg), "flare")
• SendTo (line 255): baseURL, _ := configUtils.AddAgentVersionToDomain(url, "flare")

After:

• Both call buildFlareBaseURL(url) which wraps configUtils.AddAgentVersionToDomain(url, "flare")

Test plan

• go test -tags test ./comp/core/flare/helpers/... — all pass
• dda inv linter.go --targets=./comp/core/flare/helpers — 0 issues

Fixes AGENTCFG-63

Created by Auto-JIRA.

[rahulkaukuntla]

@codex review

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Can't wait for the next one!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[agent-platform-auto-pr]

Files inventory check summary

File checks results against ancestor 17ae85ff:

Results for datadog-agent_7.79.0~devel.git.104.f06eded.pipeline.104179500-1_amd64.deb:

No change detected

[agent-platform-auto-pr]

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 17ae85f
📊 Static Quality Gates Dashboard
🔗 SQG Job

30 successful checks with minimal change (< 2 KiB)

	Quality gate	Current Size
✅	agent_deb_amd64	752.807 MiB
✅	agent_deb_amd64_fips	709.763 MiB
✅	agent_heroku_amd64	313.157 MiB
✅	agent_rpm_amd64	752.791 MiB
✅	agent_rpm_amd64_fips	709.746 MiB
✅	agent_rpm_arm64	731.153 MiB
✅	agent_rpm_arm64_fips	691.140 MiB
✅	agent_suse_amd64	752.791 MiB
✅	agent_suse_amd64_fips	709.746 MiB
✅	agent_suse_arm64	731.153 MiB
✅	agent_suse_arm64_fips	691.140 MiB
✅	docker_agent_amd64	813.117 MiB
✅	docker_agent_arm64	816.241 MiB
✅	docker_agent_jmx_amd64	1004.033 MiB
✅	docker_agent_jmx_arm64	995.936 MiB
✅	docker_cluster_agent_amd64	205.320 MiB
✅	docker_cluster_agent_arm64	219.677 MiB
✅	docker_cws_instrumentation_amd64	7.142 MiB
✅	docker_cws_instrumentation_arm64	6.689 MiB
✅	docker_dogstatsd_amd64	39.230 MiB
✅	docker_dogstatsd_arm64	37.445 MiB
✅	dogstatsd_deb_amd64	29.874 MiB
✅	dogstatsd_deb_arm64	28.026 MiB
✅	dogstatsd_rpm_amd64	29.874 MiB
✅	dogstatsd_suse_amd64	29.874 MiB
✅	iot_agent_deb_amd64	43.262 MiB
✅	iot_agent_deb_arm64	40.309 MiB
✅	iot_agent_deb_armhf	41.052 MiB
✅	iot_agent_rpm_amd64	43.262 MiB
✅	iot_agent_suse_amd64	43.262 MiB

On-wire sizes (compressed)

	Quality gate	Change	Size (prev → curr → max)
✅	agent_deb_amd64	-17.46 KiB (0.01% reduction)	174.826 → 174.809 → 178.360
✅	agent_deb_amd64_fips	-36.41 KiB (0.02% reduction)	165.420 → 165.385 → 172.790
✅	agent_heroku_amd64	+2.58 KiB (0.00% increase)	74.982 → 74.985 → 79.970
✅	agent_rpm_amd64	+19.78 KiB (0.01% increase)	177.661 → 177.680 → 181.830
✅	agent_rpm_amd64_fips	-7.47 KiB (0.00% reduction)	167.720 → 167.713 → 173.370
✅	agent_rpm_arm64	+8.09 KiB (0.00% increase)	159.604 → 159.612 → 163.060
✅	agent_rpm_arm64_fips	neutral	151.461 MiB → 156.170
✅	agent_suse_amd64	+19.78 KiB (0.01% increase)	177.661 → 177.680 → 181.830
✅	agent_suse_amd64_fips	-7.47 KiB (0.00% reduction)	167.720 → 167.713 → 173.370
✅	agent_suse_arm64	+8.09 KiB (0.00% increase)	159.604 → 159.612 → 163.060
✅	agent_suse_arm64_fips	neutral	151.461 MiB → 156.170
✅	docker_agent_amd64	+11.17 KiB (0.00% increase)	268.255 → 268.266 → 272.480
✅	docker_agent_arm64	-3.44 KiB (0.00% reduction)	255.465 → 255.462 → 261.060
✅	docker_agent_jmx_amd64	+4.82 KiB (0.00% increase)	336.907 → 336.912 → 341.100
✅	docker_agent_jmx_arm64	neutral	320.099 MiB → 325.620
✅	docker_cluster_agent_amd64	neutral	71.926 MiB → 72.920
✅	docker_cluster_agent_arm64	+4.41 KiB (0.01% increase)	67.499 → 67.503 → 68.220
✅	docker_cws_instrumentation_amd64	neutral	2.999 MiB → 3.330
✅	docker_cws_instrumentation_arm64	neutral	2.729 MiB → 3.090
✅	docker_dogstatsd_amd64	neutral	15.169 MiB → 15.820
✅	docker_dogstatsd_arm64	neutral	14.490 MiB → 14.830
✅	dogstatsd_deb_amd64	neutral	7.889 MiB → 8.790
✅	dogstatsd_deb_arm64	neutral	6.776 MiB → 7.710
✅	dogstatsd_rpm_amd64	neutral	7.900 MiB → 8.800
✅	dogstatsd_suse_amd64	neutral	7.900 MiB → 8.800
✅	iot_agent_deb_amd64	neutral	11.393 MiB → 12.040
✅	iot_agent_deb_arm64	neutral	9.699 MiB → 10.450
✅	iot_agent_deb_armhf	neutral	9.934 MiB → 10.620
✅	iot_agent_rpm_amd64	neutral	11.412 MiB → 12.060
✅	iot_agent_suse_amd64	neutral	11.412 MiB → 12.060

[cit-pr-commenter-54b7da]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: a0a0bbb9-3bae-44de-828d-f0c94abe6e20

Baseline: 17ae85f
Comparison: f06eded
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	-3.44	[-6.39, -0.49]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_metrics_logs	memory utilization	+1.15	[+0.92, +1.39]	1	Logs bounds checks dashboard
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	+0.63	[+0.57, +0.69]	1	Logs
➖	ddot_metrics_sum_delta	memory utilization	+0.56	[+0.38, +0.73]	1	Logs
➖	ddot_metrics_sum_cumulative	memory utilization	+0.43	[+0.29, +0.57]	1	Logs
➖	ddot_logs	memory utilization	+0.20	[+0.14, +0.26]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	+0.17	[+0.00, +0.33]	1	Logs
➖	ddot_metrics_sum_cumulativetodelta_exporter	memory utilization	+0.12	[-0.11, +0.34]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.06	[-0.37, +0.48]	1	Logs
➖	otlp_ingest_metrics	memory utilization	+0.05	[-0.11, +0.21]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.04	[+0.01, +0.08]	1	Logs bounds checks dashboard
➖	file_to_blackhole_100ms_latency	egress throughput	+0.04	[-0.07, +0.14]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.01	[-0.51, +0.52]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.20, +0.20]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.12, +0.11]	1	Logs
➖	uds_dogstatsd_to_api_v3	ingress throughput	-0.00	[-0.22, +0.21]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.01	[-0.40, +0.38]	1	Logs
➖	quality_gate_idle	memory utilization	-0.04	[-0.10, +0.01]	1	Logs bounds checks dashboard
➖	quality_gate_logs	% cpu utilization	-0.06	[-1.65, +1.52]	1	Logs bounds checks dashboard
➖	ddot_metrics	memory utilization	-0.17	[-0.36, +0.01]	1	Logs
➖	otlp_ingest_logs	memory utilization	-0.26	[-0.36, -0.16]	1	Logs
➖	file_tree	memory utilization	-0.33	[-0.38, -0.27]	1	Logs
➖	docker_containers_memory	memory utilization	-0.34	[-0.42, -0.26]	1	Logs
➖	docker_containers_cpu	% cpu utilization	-3.44	[-6.39, -0.49]	1	Logs

Bounds Checks: ❌ Failed

perf	experiment	bounds_check_name	replicates_passed	observed_value	links
✅	docker_containers_cpu	simple_check_run	10/10	718 ≥ 26
✅	docker_containers_memory	memory_usage	10/10	279.02MiB ≤ 370MiB
✅	docker_containers_memory	simple_check_run	10/10	702 ≥ 26
✅	file_to_blackhole_0ms_latency	memory_usage	10/10	0.19GiB ≤ 1.20GiB
✅	file_to_blackhole_0ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10	0.23GiB ≤ 1.20GiB
✅	file_to_blackhole_1000ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_100ms_latency	memory_usage	10/10	0.19GiB ≤ 1.20GiB
✅	file_to_blackhole_100ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_500ms_latency	memory_usage	10/10	0.21GiB ≤ 1.20GiB
✅	file_to_blackhole_500ms_latency	missed_bytes	10/10	0B = 0B
✅	quality_gate_idle	intake_connections	10/10	3 = 3	bounds checks dashboard
❌	quality_gate_idle	memory_usage	9/10	175.46MiB > 175MiB	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	2 ≤ 3	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	491.42MiB ≤ 550MiB	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	3 ≤ 6	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	206.44MiB ≤ 220MiB	bounds checks dashboard
✅	quality_gate_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	346.37 ≤ 2000	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	412.21MiB ≤ 475MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

❌ Failed. Some Quality Gates were violated.

• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 9/10 replicas passed. Failed 1 which is > 0. Gate FAILED.
• quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.