configs/config.protectli_vp2420_no_emmc: create viariant with disable…#893
Open
wiktormowinski wants to merge 1 commit into
Open
configs/config.protectli_vp2420_no_emmc: create viariant with disable…#893wiktormowinski wants to merge 1 commit into
wiktormowinski wants to merge 1 commit into
Conversation
…d emmc Adds ENABLE_EMMC option (default y) to support VP2420e — a hardware variant without eMMC. SMBIOS product name gets an "e" suffix when the option is disabled. `ScsEmmcEnabled` is set by `soc_silicon_init_params()` via `is_devfn_enabled(PCH_DEVFN_EMMC)` before `mainboard_silicon_init_params()` is called, so overriding it directly in FSP UPD at the end of `mainboard_silicon_init_params()` is sufficient. `pcidev_path_on_root(PCH_DEVFN_EMMC)->enabled` is also cleared to prevent the device from appearing in ACPI tables. Upstream-Status: Pending Signed-off-by: Wiktor Mowinski <wiktor.mowinski@3mdeb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…d emmc
Adds ENABLE_EMMC option (default y) to support VP2420e — a hardware variant without eMMC. SMBIOS product name gets an "e" suffix when the option is disabled.
ScsEmmcEnabledis set bysoc_silicon_init_params()viais_devfn_enabled(PCH_DEVFN_EMMC)beforemainboard_silicon_init_params()is called, so overriding it directly in FSP UPD at the end ofmainboard_silicon_init_params()is sufficient.pcidev_path_on_root(PCH_DEVFN_EMMC)->enabledis also cleared to prevent the device from appearing in ACPI tables.