Skip to content

fix #5479: navigate back to correct item path after deleting custom URL#5491

Open
guillermo-escire wants to merge 2 commits intoDSpace:mainfrom
guillermo-escire:feature/5479
Open

fix #5479: navigate back to correct item path after deleting custom URL#5491
guillermo-escire wants to merge 2 commits intoDSpace:mainfrom
guillermo-escire:feature/5479

Conversation

@guillermo-escire
Copy link
Copy Markdown
Contributor

References

Fixes #5479

Description

After deleting a custom URL (dspace.customurl) from an item via Administer, the "Back" button now correctly navigates to the item's UUID-based path instead of the deleted custom URL.

Instructions for Reviewers

List of changes in this PR:

  • edit-item-page.component.ts: Updated getItemPage() to extract the UUID directly from the current edit URL instead of relying on item metadata, avoiding navigation to a potentially deleted custom URL.
  • item-page.resolver.ts: Added a check to prevent the resolver from redirecting to the custom URL when navigating back from an edit/administer page.
  • Updated specs for both files accordingly.

Steps to test:

  1. Go to an item page that has dspace.customurl set
  2. Click the three-dot menu → Administer
  3. In the Metadata tab, delete the dspace.customurl field and click Save
  4. Click Back
  5. Verify that it navigates to the correct item page via UUID (not a 404)
  6. Refresh the page and verify it stays on the correct item page

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@lgeggleston lgeggleston added bug 1 APPROVAL pull request only requires a single approval to merge testathon Reported by a tester during Community Testathon DSpace-CRIS merger This ticket/PR relates to the merger of DSpace-CRIS into DSpace. labels Apr 16, 2026
@lgeggleston lgeggleston moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge bug DSpace-CRIS merger This ticket/PR relates to the merger of DSpace-CRIS into DSpace. testathon Reported by a tester during Community Testathon

Projects

Status: 🙋 Needs Reviewers Assigned

Development

Successfully merging this pull request may close these issues.

Cannot navigate back to current item path after deleting custom URL

2 participants