Skip to content

Clear protected_domains in detection rules#139

Merged
Zacgoose merged 1 commit intomainfrom
dev
Apr 8, 2026
Merged

Clear protected_domains in detection rules#139
Zacgoose merged 1 commit intomainfrom
dev

Conversation

@Zacgoose
Copy link
Copy Markdown
Contributor

@Zacgoose Zacgoose commented Apr 8, 2026

Removed all entries from the protected_domains list.

Removed all entries from the protected_domains list.

Signed-off-by: Zacgoose <107489668+Zacgoose@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 8, 2026 03:25
@Zacgoose Zacgoose merged commit c5bb7e5 into main Apr 8, 2026
3 checks passed
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the default seed list of protected domains used by the domain_squatting detection configuration, leaving the feature with no built-in protected targets.

Changes:

  • Cleared domain_squatting.protected_domains in the detection rules configuration.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

"githubusercontent.com",
"azurestaticapps.net"
],
"protected_domains": [],
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting domain_squatting.protected_domains to an empty list effectively disables domain-squatting detections out of the box: DomainSquattingDetector.checkDomain() iterates only over this.protectedDomains and returns null when the list is empty, so no squatting signals can ever be produced unless runtime config or the URL allowlist populates domains. This also causes the Options UI flow that displays “Default Protected Domains” to always warn "No default protected domains found" (options/options.js:3753-3755). If the intent is only to remove the baked-in defaults, consider also disabling domain_squatting by default or providing an alternate source/seed list so the feature remains functional and the UI doesn’t degrade.

Suggested change
"protected_domains": [],
"protected_domains": [
"login.microsoftonline.com",
"login.microsoft.com",
"login.microsoft.net",
"login.windows.net",
"login.partner.microsoftonline.cn",
"login.live.com"
],

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants