fix: MCP Manager Add Stdio Server form improvements#223
Open
sungdark wants to merge 1 commit intoCortexLM:mainfrom
Open
fix: MCP Manager Add Stdio Server form improvements#223sungdark wants to merge 1 commit intoCortexLM:mainfrom
sungdark wants to merge 1 commit intoCortexLM:mainfrom
Conversation
Fixes two validated bounty challenge bugs: 1. MCP Manager Add Stdio Server form now shows '- Stdio' suffix in the header, matching other server type forms (HTTP, Registry). Fixes PlatformNetwork/bounty-challenge#40908 2. When Enter is pressed with empty Name or Command fields, a red error message now appears instead of silently doing nothing. Error clears automatically when user starts typing. Fixes PlatformNetwork/bounty-challenge#40906 收款地址：eB51DWp1uECrLZRLsE2cnyZUzfRWvzUzaJzkatTpQV9
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
This was referenced Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two validated bounty challenge bugs in the MCP Manager Add Stdio Server form:
Fix 1: Missing form header (#40908)
The Add Stdio Server form now shows
Add MCP Server - Stdioas the title, matching the pattern of other server type forms (HTTP shows- HTTP, Registry shows- Registry).Before:
Add MCP ServerAfter:
Add MCP Server - StdioFix 2: Silent failure on empty fields (#40906)
When pressing Enter with empty Name or Command fields, the form now displays a red error message instead of silently doing nothing.
Error messages:
Error: Name and Command are requiredError: Server name is requiredError: Command is requiredThe error automatically clears when the user starts typing or presses Tab to switch fields.
Files changed
src/cortex-tui/src/modal/mcp_manager/types.rs- Addederror: Option<String>field toAddStdioServermodesrc/cortex-tui/src/modal/mcp_manager/handlers.rs- Set error on empty submit, clear on typingsrc/cortex-tui/src/modal/mcp_manager/rendering.rs- Render error message + fixed titlesrc/cortex-tui/src/modal/mcp_manager/mod.rs- Updated paste handler to handle new fieldBounty References
收款地址：eB51DWp1uECrLZRLsE2cnyZUzfRWvzUzaJzkatTpQV9