Glasgow | 26- SDC-Mar | Taras Mykytiuk | Sprint 5 | Implement laptop allocation #519
Open
TarasMykytiuk wants to merge 1 commit into
Open
Glasgow | 26- SDC-Mar | Taras Mykytiuk | Sprint 5 | Implement laptop allocation #519TarasMykytiuk wants to merge 1 commit into
TarasMykytiuk wants to merge 1 commit into
Conversation
TarasMykytiuk
added
Needs Review
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
May 13, 2026
Contributor
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work on this task,looks good
Contributor
There was a problem hiding this comment.
Good work adding lots of test cases here
| if sys == laptop.operating_system: | ||
| alloc_dict[person] = laptop | ||
| laptops.pop(laptops.index(laptop)) | ||
| is_match = True |
Contributor
There was a problem hiding this comment.
Good idea to have early breaks when appropriate matches found
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Laptop allocation task is done.