London | 26-ITP-May | Remi M. B. | Sprint 1 | Form Controls#1258
Open
remimarcelle wants to merge 9 commits into
Open
London | 26-ITP-May | Remi M. B. | Sprint 1 | Form Controls#1258remimarcelle wants to merge 9 commits into
remimarcelle wants to merge 9 commits into
Conversation
…ng requirement for fingers, improves accessibility
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Author
|
It seems I accidently committed code from the wireframe task in this pull request? Idk how |
Author
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Self checklist
Changelist
Built a form to collect t-shirt orders using HTML only. It asks for the
customer's full name, email address, t-shirt colour (radio buttons) and
size (dropdown). Wrapped inputs and radio button labels in p tags to add
spacing between touch targets, bringing the Lighthouse accessibility
score from 92 to 100.
Questions
Do I have to screenshot that I used devtools to refactor before I changed the code in vscode?