Skip to content

London | 26-ITP-May | Remi M. B. | Sprint 1 | Form Controls#1258

Open
remimarcelle wants to merge 9 commits into
CodeYourFuture:mainfrom
remimarcelle:feature/form-controls
Open

London | 26-ITP-May | Remi M. B. | Sprint 1 | Form Controls#1258
remimarcelle wants to merge 9 commits into
CodeYourFuture:mainfrom
remimarcelle:feature/form-controls

Conversation

@remimarcelle
Copy link
Copy Markdown

@remimarcelle remimarcelle commented May 12, 2026

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide
  • I have only used HTML, no CSS or JavaScript
  • My form is semantic HTML
  • All inputs have associated labels
  • My Lighthouse Accessibility score is 100
  • I require a valid name (minimum 2 characters)
  • I require a valid email
  • I require one colour from a defined set of 3 colours
  • I require one size from a defined set of 6 sizes
  • My code is consistently formatted
  • My page content is free of typos
  • I commit often and push regularly to GitHub
  • My HTML code has no errors or warnings (https://validator.w3.org/)

Changelist

Built a form to collect t-shirt orders using HTML only. It asks for the
customer's full name, email address, t-shirt colour (radio buttons) and
size (dropdown). Wrapped inputs and radio button labels in p tags to add
spacing between touch targets, bringing the Lighthouse accessibility
score from 92 to 100.

Questions

Do I have to screenshot that I used devtools to refactor before I changed the code in vscode?

@netlify
Copy link
Copy Markdown

netlify Bot commented May 12, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 41f5028
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a03a51f55e45500084f84fb
😎 Deploy Preview https://deploy-preview-1258--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@remimarcelle remimarcelle added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 12, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 12, 2026
@remimarcelle remimarcelle changed the title London | 26-ITP-May | Remi M. B. | Onboarding-Sprint 1 | Form Controls London | 26-ITP-May | Remi M. B. | Sprint 1 | Form Controls May 12, 2026
@github-actions

This comment has been minimized.

@remimarcelle remimarcelle added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 12, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 12, 2026
@remimarcelle remimarcelle added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 12, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 12, 2026
@github-actions

This comment has been minimized.

@remimarcelle
Copy link
Copy Markdown
Author

It seems I accidently committed code from the wireframe task in this pull request? Idk how

@remimarcelle remimarcelle added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 12, 2026
@remimarcelle
Copy link
Copy Markdown
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant