London | 26-ITP-May | Boualem Larbi Djebbour | Sprint 2 | wireframe#1255
Open
djebsoft wants to merge 35 commits into
Open
London | 26-ITP-May | Boualem Larbi Djebbour | Sprint 2 | wireframe#1255djebsoft wants to merge 35 commits into
djebsoft wants to merge 35 commits into
Conversation
Updated content and structure of the wireframe HTML.
Replaced placeholder image with a new icon image.
Removed starter styles and design palette comments. Updated styles for body, header, main, articles, article, and footer.
Removed inline styles from images for consistency.
Refactor CSS variables and update styles for body and main elements.
Change image and SVG width to 50% and set height to 100%.
Reduced container width and adjusted main padding.
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
djebsoft
added
the
Needs Review
cjyuan
reviewed
May 12, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
The code looks good.
I noticed one or two misspelled words in the page content. Can you use an AI tool to locate them, and then fix them?
| This is the default, provided code and no changes have been made yet. | ||
| </p> | ||
| <h1>Wireframe task</h1> | ||
| <p>what is wireframe, readme file and git branch ?</p> |
Contributor
There was a problem hiding this comment.
Any reason to start a sentence with a lowercase letter?
| <article> | ||
| <img src="placeholder.svg" alt="" /> | ||
| <h2>Title</h2> | ||
| <img src="readme_image.png" alt="" /> |
Contributor
There was a problem hiding this comment.
Providing meaningful alt text is important because it ensures images are accessible to people using screen readers and also helps when images fail to load, giving users essential context about the content or function of the image.
cjyuan
added
Reviewed
djebsoft
added
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
This PR previously discussed in #1158
changes since last PR: fixed some typos and centered the image