Skip to content

Manchester | 26-ITP-May | Monsur Abdulrahman | Sprint 2 | Wireframe #1241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Monsur0001 wants to merge 6 commits into
base: main
Choose a base branch
from
+68 −14
Open

Manchester | 26-ITP-May | Monsur Abdulrahman | Sprint 2 | Wireframe #1241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f21d9eb
What is a REAADME File?
Monsur0001 Apr 11, 2026
4735988
Purpose of a Wireframe
Monsur0001 Apr 11, 2026
2c16dc3
What is branch in Git?
Monsur0001 Apr 11, 2026
e5260c4
Features/Wireframe updated
Monsur0001 Apr 11, 2026
aaa453c
What is branch in Git updated
Monsur0001 Apr 11, 2026
d79befd
What is branch in Git? updated
Monsur0001 May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 42 additions & 13 deletions Wireframe/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,33 +1,62 @@
<!DOCTYPE html>
<!doctype html>
<html lang="en">
<head>
Copy link
Copy Markdown

@Sambuxc Sambuxc May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your page head should include a title and description

Copy link
Copy Markdown
Author

@Monsur0001 Monsur0001 May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for your feedback. I have added the description as suggested.

Copy link
Copy Markdown

@Sambuxc Sambuxc May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How have you linked your html to the style.css file?

Copy link
Copy Markdown
Author

@Monsur0001 Monsur0001 May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your feedback. I have linked my css with this line of code ""

<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Wireframe</title>
<meta name="description" content="A project practising wireframes and Git commits.">
<link rel="stylesheet" href="style.css" />
</head>
<body>
<header>
<h1>Wireframe</h1>
<p>
This is the default, provided code and no changes have been made yet.
</p>
<h1 class="center">Wireframe & Git Commits</h1>
<p class="center">Practicing commits in Git</p>
</header>
<main>
<main class="container">
<article>
<img src="placeholder.svg" alt="" />
<h2>Title</h2>
<img
src="https://img.freepik.com/premium-vector/wireframe-icon_933463-14328.jpg"
alt=""
/>
<h2>README File</h2>
<p>
Lorem ipsum dolor sit amet consectetur adipisicing elit. Quisquam,
voluptates. Quisquam, voluptates.
A README File explains what the project is, how to use it and why it
exists.
</p>
<a href="">Read more</a>
</article>
</main>

<main class="article-row">
<article>
<img
src="https://img.freepik.com/premium-vector/wireframe-icon_933463-14328.jpg"
alt=""
/>
<h2>The purpose of a Wireframe</h2>
<p>
A wireframe is a basic visual layout of a website or application. It
shows structure of the project.
</p>
<a href="">Read more</a>
</article>

<article>
<img
src="https://img.freepik.com/premium-vector/wireframe-icon_933463-14328.jpg"
alt=""
/>
<h2>What is a branch in Git?</h2>
<p>
A branch is a separate line of development. It allows developers to
work on changes without affecting the main codebase.
</p>
<a href="">Read more</a>
</article>
</main>

<footer>
<p>
This is the default, provided code and no changes have been made yet.
</p>
<p>Designed with love by Monsur Abdulrahman 2026</p>
</footer>
</body>
</html>
27 changes: 26 additions & 1 deletion Wireframe/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ body {
background: var(--paper);
color: var(--ink);
font: var(--font);
margin: 50px;
}
a {
padding: var(--space);
Expand All @@ -52,6 +53,7 @@ main {
footer {
position: fixed;
Copy link
Copy Markdown

@Sambuxc Sambuxc May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you decide to remove the fixed position?

Copy link
Copy Markdown
Author

@Monsur0001 Monsur0001 May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for your feedback. I noticed that when I leave the fixed position, I realized that my footer aligns back to the left instead of staying at the center. However, after deep research about the issue, I found that adding a width of 100% would easily solve the problem. I have made the correction immediately.

Copy link
Copy Markdown

@Sambuxc Sambuxc May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks much better now, however the text becomes unreadable when scrolling at the background shows the page content through it.
Can you think of a way to make sure the text either; does not overlap the page content when scroll, or has an appropriate background color to make the footer text always readable?

bottom: 0;
width: 100%;
text-align: center;
}
/* ====== Articles Grid Layout ====
Expand All @@ -68,6 +70,7 @@ main {
> *:first-child {
grid-column: span 2;
}

}
/* ====== Article Layout ======
Setting the rules for how elements are placed in the article.
Expand All @@ -80,10 +83,32 @@ article {
text-align: left;
display: grid;
grid-template-columns: var(--space) 1fr var(--space);

> * {
grid-column: 2/3;
}
> img {
grid-column: span 3;
grid-column: span 2;

}


}

article img {
width: 100%;
height: 300px;
object-fit: fill;
}

.article-row {
grid-column: 1 / -1;
display: grid;
grid-template-columns: 1fr 1fr;
margin-top: 30px;
gap: var(--space);
}

.center {
text-align: center;
}
Loading