Glasgow | 26-ITP-May | Chan Yat Long | Sprint 1 | Form Control #1225
Open
Motorcycle-lab wants to merge 4 commits into
Open
Glasgow | 26-ITP-May | Chan Yat Long | Sprint 1 | Form Control #1225Motorcycle-lab wants to merge 4 commits into
Motorcycle-lab wants to merge 4 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
3 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Motorcycle-lab
changed the title
Motorcycle-lab
added
Needs Review
Poonam-raj
added
🐂 Size Medium
This comment has been minimized.
This comment has been minimized.
4 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Poonam-raj
removed
🐂 Size Medium
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
|
Hi Chan, please look at this pull request again - I don't want to review it until you've taken out the unrelated code (wireframe) please remove all work relating to wireframe so the only file changed is the form control html page. |
Poonam-raj
added
Reviewed
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Author
|
Motorcycle-lab
added
Needs Review
WeiTsungCheng
added
Review in progress
|
|
||
| <label for="email">Your Email:</label> | ||
| <input id="email" type="email" required> | ||
| <button id="go"> Go |
There was a problem hiding this comment.
It's best to include a name in the input field. Or the form won't include the data when you submit it
| try writing out the requirements first as comments | ||
| this will also help you fill in your PR message later--> | ||
| <label for="user-name">Your Name:</label> | ||
| <input id="user-name" type="text" pattern="[A-Za-z\s]{2,}" title="Please enter at least 2 letters. Numbers and symbols are not allowed" required> |
There was a problem hiding this comment.
[A-Za-z\s]{2,} 是 ok
but if a user's name is like me (WEI-TSUNG) would get trouble
| <input id="email" type="email" required> | ||
| <button id="go"> Go | ||
| </button> | ||
|
|
There was a problem hiding this comment.
Although the Button has a default type, it is still recommended to specify it explicitly.
| </html> | ||
| <footer> | ||
| <!-- change to your name--> | ||
| <p>By HOMEWORK SOLUTION</p> |
| <option value="blue">M</option> | ||
| <option value="green">L</option> | ||
| <option value="green">XL</option> | ||
| <option value="green">XXL</option> |
There was a problem hiding this comment.
This is incorrectly expressed.
Besides some duplicate values, the value of size should not be color.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
I finished the requirement of the form control.
I have improved the grammar of the html that I have formed.