London | 26-ATP-May | Boualem Larbi Djebbour | sprint 3 | Alarm clock app#1230
Open
djebsoft wants to merge 9 commits into
Open
London | 26-ATP-May | Boualem Larbi Djebbour | sprint 3 | Alarm clock app#1230djebsoft wants to merge 9 commits into
djebsoft wants to merge 9 commits into
Conversation
…pes in the input field.
… user types in the input field." This reverts commit adf628a.
…e user types in the input field.
djebsoft
added
the
Needs Review
Member
illicitonion
left a comment
illicitonion
left a comment
There was a problem hiding this comment.
This looks good, but has one issue - if I set the alarm for 1 second, the alarm only actually plays after 2 seconds. Can you work out why and fix it up?
| @@ -1,5 +1,53 @@ | |||
| function setAlarm() {} | |||
| //global variables: 1- userInput, 2- timeRemaining, 3- stop, 4- seconds, 5- minutes | |||
Member
There was a problem hiding this comment.
Please take a look at all of your comments in this file and see if they add more detail than just the line of code itself. e.g. the comment get access to the "timeRemaining" element simply restates exactly what the line after does. Remove any that aren't useful.
Comments should ideally be replaced by clear naming with code, and where they can't, should typically explain why we're doing something, rather than what we're doing. The code itself says what we're doing.
illicitonion
added
Reviewed
djebsoft
added
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
This PR previously discussed in #1144
changes since last PR: no changes