London | 26-SDC-Mar | Ebrahim Beiati-Asl | Sprint 2 | implement_skip_list#155
Open
ebrahimbeiati wants to merge 1 commit into
Open
London | 26-SDC-Mar | Ebrahim Beiati-Asl | Sprint 2 | implement_skip_list#155ebrahimbeiati wants to merge 1 commit into
ebrahimbeiati wants to merge 1 commit into
Conversation
ebrahimbeiati
added
the
Needs Review
cjyuan
reviewed
May 17, 2026
|
|
||
| if pos < len(self.data) and self.data[pos] == value: | ||
| return # value already exists, do not insert duplicates | ||
| self.data.insert(pos, value) |
There was a problem hiding this comment.
This insertion operation is O(n), which does not meet the requirement.
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist