Skip to content

fix: correct shell config bugs in .zshrc and .zsh_aliases#6

Open
tschulze wants to merge 1 commit intoCodeOpsHQ:mainfrom
tschulze:fix/shell-config-bugs
Open

fix: correct shell config bugs in .zshrc and .zsh_aliases#6
tschulze wants to merge 1 commit intoCodeOpsHQ:mainfrom
tschulze:fix/shell-config-bugs

Conversation

@tschulze
Copy link
Copy Markdown

@tschulze tschulze commented May 2, 2026

Summary

  • Remove trailing visudo from EDITOR and VISUAL exports in .zshrc and .zsh_aliases — the value was being set to "nvim visudo" instead of "nvim", breaking any tool that invokes $EDITOR
  • Guard the fzf preview alias with a bat availability check and fall back to cat when bat is not installed
  • Fix missing # on the Zoxide and Tmuxifier comment lines in .zshrc (bare text was being executed as commands)
  • Comment out the zoxide and tmuxifier eval lines
  • Rename zsh-syntax-highlightin-tokyonight.zshzsh-syntax-highlighting-tokyonight.zsh (missing g)
  • Remove a duplicate _SKIP_* variable block that was accidentally pasted inside the nnn plugin if-block in .zsh_aliases, causing all those variables to be reset whenever nnn is installed

Test plan

  • Source .zshrc and verify echo $EDITOR returns nvim
  • Verify fzf preview works with and without bat installed
  • Confirm no shell errors on startup related to the Zoxide/Tmuxifier lines

Summary by CodeRabbit

  • Bug Fixes

    • Corrected editor environment variables to remove accidental trailing text.
    • Fixed typo in sourced script filename.
    • Disabled runtime initialization for certain tools to prevent conflicts.
  • Improvements

    • Enhanced preview command to intelligently use available tools based on system configuration.

- Remove trailing 'visudo' from EDITOR and VISUAL exports in .zshrc
  and .zsh_aliases — value was set to "nvim visudo" instead of "nvim"
- Guard fzf preview alias with a bat availability check, fall back
  to cat when bat is not installed
- Fix missing '#' on Zoxide and Tmuxifier comment lines in .zshrc
- Comment out zoxide and tmuxifier eval lines in .zshrc
- Rename zsh-syntax-highlightin-tokyonight.zsh (missing 'g')
- Remove duplicate _SKIP_* variable block accidentally pasted inside
  the nnn plugin if-block in .zsh_aliases
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3d05d72d-c766-4bd7-b7ce-0790b94962e0

📥 Commits

Reviewing files that changed from the base of the PR and between 88918fe and e483986.

📒 Files selected for processing (3)
  • .config/alias/.zsh_aliases
  • .config/zsh/zsh-syntax-highlighting-tokyonight.zsh
  • .zshrc

📝 Walkthrough

Walkthrough

Shell configuration files are corrected to remove accidental visudo text from EDITOR/VISUAL exports, fix a typo in the zsh-syntax-highlighting script filename, make the fzf preview command conditional on bat availability, and disable zoxide and tmuxifier initialization.

Changes

Shell Configuration Cleanup

Layer / File(s) Summary
Environment Variable Fixes
.config/alias/.zsh_aliases, .zshrc
EDITOR and VISUAL exports corrected to remove the unintended visudo suffix; both now export only vim and nvim respectively.
Conditional Tool Integration
.zshrc
fzf alias preview command now conditionally uses bat when installed, falling back to cat otherwise.
Script Sourcing & Initialization
.zshrc
Typo in zsh-syntax-highlighting tokyo-night script filename is fixed; zoxide and tmuxifier eval init blocks are commented out while preserving configuration comments.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A rabbit hops through configs bright,
Removing visudo—cleaning up the sight,
With bat as a friend and typos all gone,
The shell flows more smoothly from dusk until dawn!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main purpose of the changeset—fixing multiple shell configuration bugs in .zshrc and .zsh_aliases files, which aligns with the PR's comprehensive objectives including editor variable fixes, fzf alias improvements, and zoxide/tmuxifier corrections.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 60 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant