Skip to content

fix: fix segfault caused by multiple activate_stack_trampoline#109

Merged
GuillaumeLagrange merged 2 commits intomasterfrom
cod-2202-intermittent-crashes-on-codspeed-macro
Mar 30, 2026
Merged

fix: fix segfault caused by multiple activate_stack_trampoline#109
GuillaumeLagrange merged 2 commits intomasterfrom
cod-2202-intermittent-crashes-on-codspeed-macro

Conversation

@GuillaumeLagrange
Copy link
Copy Markdown
Contributor

@GuillaumeLagrange GuillaumeLagrange commented Mar 27, 2026

Fixes #106

Upstream CPython issue: python/cpython#146522

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 27, 2026

Merging this PR will degrade performance by 12.47%

⚡ 23 improved benchmarks
❌ 26 (👁 26) regressed benchmarks
✅ 228 untouched benchmarks

Performance Changes

Mode Benchmark BASE HEAD Efficiency
👁 WallTime test_hostname_resolution[localhost] 122.7 µs 125.7 µs -2.42%
👁 WallTime test_fs_read[1000] 797.1 ns 831.9 ns -4.18%
WallTime test_make_lowpass 6.1 µs 5.6 µs +7.46%
WallTime test_threadpool_map[10] 2.6 ms 2.5 ms +2.42%
👁 WallTime test_hostname_resolution[google.com] 393.4 µs 403.3 µs -2.46%
WallTime test_pipe_communication[10000] 14.9 ms 12.6 ms +18.71%
WallTime test_generate_all_combinations[5-4] 10.6 µs 10.2 µs +4.53%
WallTime test_make_peak 6.8 µs 6.5 µs +5.43%
WallTime test_multiprocessing_map[10000] 126.5 ms 92.2 ms +37.19%
👁 WallTime test_match_word_pattern[aba-GraphTreesGraph] 98.6 µs 102.9 µs -4.23%
WallTime test_iir_filter_process 3.1 µs 2.9 µs +6.74%
👁 WallTime test_array_alloc[100] 1.1 µs 1.2 µs -5.58%
WallTime test_make_bandpass 5.9 µs 5.4 µs +10.29%
👁 WallTime test_open_close_fd[10] 93.4 µs 96.4 µs -3.06%
WallTime test_noop_pass 506.2 ns 485.9 ns +4.19%
👁 WallTime test_sum_of_squares[sum_of_squares_sum_labmda_product] 251.3 µs 273.8 µs -8.19%
👁 WallTime test_hostname_resolution[1.1.1.1] 7.5 µs 7.9 µs -4.57%
👁 WallTime test_process_creation[echo hello] 2.4 ms 2.5 ms -2.42%
👁 WallTime test_generate_all_subsequences[sequence1] 96.4 µs 98.8 µs -2.46%
👁 WallTime test_is_complete[board0] 1.8 µs 1.9 µs -4.38%
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.


Comparing cod-2202-intermittent-crashes-on-codspeed-macro (aa267f3) with master (c02b664)

Open in CodSpeed

@GuillaumeLagrange GuillaumeLagrange marked this pull request as ready for review March 27, 2026 15:12
We keep this bumped to avoid the benchmark perf changing as a side
effect.
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-2202-intermittent-crashes-on-codspeed-macro branch from 1610aa6 to aa267f3 Compare March 30, 2026 12:19
@GuillaumeLagrange GuillaumeLagrange merged commit aa267f3 into master Mar 30, 2026
43 checks passed
@GuillaumeLagrange GuillaumeLagrange deleted the cod-2202-intermittent-crashes-on-codspeed-macro branch March 30, 2026 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Intermittent crashes on codspeed-macro

2 participants