[WIP] don't trigger restart of fence_scsi when devices are modified and start digest is adapted accordingly#4106
Open
wenningerk wants to merge 1 commit intoClusterLabs:mainfrom
Open
Conversation
…a recurring action
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removing trigger_unfencing from pcmk__reschedule_recurring prevents the restart of the fencing-resource and scheduler just reschedules monitor where digest in the status isn't matching.
Question is why trigger_unfencing was there initially.
And I'm not sure if doing this modification here is worth the risk of missing something.
The feature (modify iscsi-disks in a running cluster that is using fence_scsi) is anyway relatively hacky and removing the monitor from the status-section has exacly the same effect.