Add explicit false fallback to image mime check#2913
Open
Alex2251 wants to merge 1 commit intoChainlit:mainfrom
Open
Add explicit false fallback to image mime check#2913Alex2251 wants to merge 1 commit intoChainlit:mainfrom
Alex2251 wants to merge 1 commit intoChainlit:mainfrom
Conversation
Alex2251
requested review from
asvishnyakov,
hayescode and
sandangel
as code owners
dosubot
Bot
added
size:XS
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #2897
Add explicit false fallback to image mime check
Summary by cubic
Add an explicit false fallback to the image MIME check in
Attachment.tsxsoisImageis always boolean and we avoid triggering image preview logic on invalid input.Written for commit 4f7491f. Summary will update on new commits. Review in cubic