Skip to content

fix: regex validation form error fixes #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
irubido merged 3 commits into from
Apr 16, 2026
Merged

fix: regex validation form error fixes #164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3b4886e
fix: regex validation form error fixes
sqhell Apr 13, 2026
81a500a
fix: localhost commmited to snap by mistake
sqhell Apr 14, 2026
550946b
fix: moving back to fork references of librustzcash for the scope of …
sqhell Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions crates/webzjs-wallet/src/bindgen/wallet.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ impl WebWallet {
match sync_handler.await {
Ok(Ok(())) => Ok(()),
Ok(Err(err_string)) => {
tracing::error!("Sync error: {}", err_string);
tracing::warn!("Sync error (will be retried by caller): {}", err_string);
Err(Error::Sync(err_string))
}
Err(panic_error) => {
Expand Down Expand Up @@ -396,7 +396,9 @@ impl WebWallet {
})
.unwrap_throw()
.join_async();
let txids = sync_handler.await.unwrap();
let txids = sync_handler.await.map_err(|e| {
Error::Generic(format!("Transaction creation thread panicked: {:?}", e))
})?;

let flattened_txid_bytes = txids.iter().flat_map(|&x| x.as_ref().clone()).collect();
Ok(flattened_txid_bytes)
Expand Down
4 changes: 2 additions & 2 deletions packages/web-wallet/src/hooks/useWebzjsActions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,15 +488,15 @@ export function useWebZjsActions(): WebzjsActions {
}
} catch (syncErr) {
consecutiveFailures++;
console.warn(`Full resync: sync round ${round} failed (${consecutiveFailures}/${MAX_CONSECUTIVE_FAILURES}):`, syncErr);
console.debug(`Full resync: sync round ${round} failed (${consecutiveFailures}/${MAX_CONSECUTIVE_FAILURES}):`, syncErr);

if (consecutiveFailures >= MAX_CONSECUTIVE_FAILURES) {
throw syncErr; // give up after too many consecutive failures
}

// Back off longer after failures
const backoff = SYNC_ROUND_DELAY * Math.pow(2, consecutiveFailures - 1);
console.info(`Full resync: backing off ${backoff}ms before retry`);
console.debug(`Full resync: backing off ${backoff}ms before retry`);
await new Promise(r => setTimeout(r, backoff));
}
}
Expand Down
9 changes: 7 additions & 2 deletions packages/web-wallet/src/utils/balance.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,17 @@ function zatsToZec(zats: number): number {
}

function zecToZats(zecAmount: string): bigint {
const trimmed = zecAmount.trim();

if (!/^\d+(\.\d+)?$/.test(zecAmount)) {
if (!/^(\d+\.?\d*|\.\d+)$/.test(trimmed)) {
throw new Error('Invalid ZEC format: must be positive number');
}

const amount = new Decimal(zecAmount);
const amount = new Decimal(trimmed);

if (!amount.isPositive() || amount.isZero()) {
throw new Error('Invalid ZEC format: must be positive number');
}

if (amount.decimalPlaces() > 8) {
throw new Error('Maximum 8 decimal places allowed');
Expand Down
Loading