Fix profile switching by replacing API call#1783
Open
Krumbthi wants to merge 1 commit intoCastagnaIT:masterfrom
Open
Fix profile switching by replacing API call#1783Krumbthi wants to merge 1 commit intoCastagnaIT:masterfrom
Krumbthi wants to merge 1 commit intoCastagnaIT:masterfrom
Conversation
…itchProfile The /api/shakti/mre/profiles/switch endpoint was removed by Netflix, causing 404 errors on profile switch. Replace with the /SwitchProfile endpoint which handles server-side profile switching, followed by a /browse fetch to obtain a fresh authURL. PIN verification is handled separately before this method is called, so the old PIN limitation of /SwitchProfile no longer applies.
|
Works for me, thank you very much! |
|
also testing working profile switch and playback on profiles with no pin |
|
When it will be released? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
Netflix seems to have removed the /api/shakti/mre/profiles/switch API, breaking profile switching with a 404 error. The /SwitchProfile?tkn=GUID endpoint was previously abandoned (May 2020) because it didn't work for PIN-locked profiles, but PIN verification is now handled separately in directory_utils.py:verify_profile_pin before activate_profile is called, making this limitation irrelevant.
Test plan
I did not test to switch to a PIN-locked profile — PIN prompt appears, switch works after entering correct PIN
Tested on: