Implement updates tracking OWID grapher#6
Open
xrendan wants to merge 1058 commits intoBuildCanada:masterfrom
Open
Implement updates tracking OWID grapher#6xrendan wants to merge 1058 commits intoBuildCanada:masterfrom
xrendan wants to merge 1058 commits intoBuildCanada:masterfrom
Conversation
Admin-only button in the DI footer that copies a plain-text version of the insight (title, body, author attribution, CTA) to clipboard, formatted for social media posting. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collection of small improvement to shared bespoke components
Causes of Death Treemap as Bespoke viz
Add 'Copy for social' button to Data Insight pages
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
🔨 (typescript) check for unused locals
Pass the full grapher config to getDatapageDataV2 for multi-dim views, instead of the partial view config from the multi-dim config. This seems like a general oversight that slipped through until now. It was uncovered thanks to an incorrect citation in "How to cite this data", which wasn't using the title from the full grapher config, where the title comes from the variable grapher config, and instead fell back to variable.display.name.
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Mirror analytics fixes from cloudflare-workers PR Ports the GA4 analytics changes from owid/cloudflare-workers#27 so the two mirrored analytics.ts files stay in sync. - Namespace Grapher query params under q_* in cf_function_invocation events. Until now `?country=DE` (a real Grapher param used by chart embeds, thumbnails, and downloads) overwrote the structured `country` field sourced from cf-ipcountry, silently corrupting the country column in dbt's raw_traffic / worker_traffic. Other query params pass through bare, except for collisions with structured names which are dropped via a reserved-key set (built from Object.keys(params) plus "status_code"). The Grapher key list comes from GRAPHER_QUERY_PARAM_KEYS in @ourworldindata/types — same source-of-truth used elsewhere in this repo (e.g. functions/_common/urlTools.ts). - Add a `host` param so the same event can carry which hostname served the request (e.g. ourworldindata.org vs api.owid.io). Drop the pathname argument from getCommonEventParams; it's derivable from request.url and was always passed by the single call site as such. - Switch from the hand-rolled parseCookies in cookieTools.ts to parseCookie from the `cookie` npm package (jshttp). Bumps the functions workspace dep to ^1.1.1 to pick up the parseCookie alias (parse is now deprecated upstream). - Add the reverse-link header comment pointing at the cloudflare-workers mirror, so future readers of either file know to update both. * 🐛🤖 Address analytics review comments * 🔨🤖 Inline analytics cookie helper
✨ hide tick marks when x-axis is shared
🔨 standardise AxisView components
🎉 (admin) add last edited note for map brackets
🔨 update regions file
Adds support for shared x-axis for faceted slope charts. This is a bit more involved because this involves a rewrite of using HorizontalAxis in slope charts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Links to issues, Figma, Slack, and a technical introduction to the work.
Screenshots / Videos / Diagrams
Add if relevant, i.e. might not be necessary when there are no UI changes.
Testing guidance
Step-by-step instructions on how to test this change
Reminder to annotate the PR diff with design notes, alternatives you considered, and any other helpful context.
Checklist
(delete all that do not apply)
Before merging
If DB migrations exists:
After merging