Conversation
|
@cubic-dev-ai review |
@melohagan I have started the AI code review. It will take a few minutes to complete. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 32ec8afb92
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…/budibase into feature/publish-changes
| $: workspaceAppChanges = $workspaceAppStore.workspaceApps.filter( | ||
| workspaceApp => workspaceApp.publishStatus?.unpublishedChanges | ||
| ).length | ||
| $: changeCount = automationChanges + workspaceAppChanges |
There was a problem hiding this comment.
Should we not add agents and tables in here?
There was a problem hiding this comment.
There were some additional changes needed (such as adding the unpublishedChanges field for agents) so I've made those in this PR: #18389
|
|
||
| setWorkspaceAppUnpublishedChanges(workspaceAppId: string) { | ||
| this.store.update(state => { | ||
| if (!state.workspaceApps[workspaceAppId]) { |
There was a problem hiding this comment.
Triggers when an app change is made in a screen within the Design section, e.g. adding a form field component, moving a component around the canvas, etc.
2 participants
Description
Count the number of changes in the publish button. If there are no changes, then just show
PublishAddresses
Screenshots
Launchcontrol
Show the number of unpublished changes directly in the Publish button and mark workspace apps as having unpublished changes when screens are saved. This makes it clear what will be published across automations, workspace apps, and tables.