Organize report-builder tests and add timeout override coverage#854
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
fd9f4dd to
0224633
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
rashmipriya12
approved these changes
May 28, 2026
rashmipriya12
left a comment
There was a problem hiding this comment.
I am assuming the fix for the failures will be done in the follow up Pr and you are fixing the tests as prep? I am approving the PR based on this assumption but if my assumption is wrong can you please explain the PR
Contributor
Author
|
The fix is this one #851 @rashmipriya12. I just found some other issues so wanted to reorganize the tests to better cover various scenarios. |
sarahboyd
approved these changes
May 28, 2026
Contributor
Coverage ReportReportReport Validation
|
|
🎉 This PR is included in version 5.2.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds new unit tests for
ReportBuildertimeout override behavior (v2 and v3) and reorganizes existing tests into logical sub-suites (status,count,timeout,duration,location,retries). Moves variable declarations and hooks to the top of suites anddescribeblocks to the bottom for consistent ordering.https://desire2learn.atlassian.net/browse/QE-2092