Skip to content

fix(start): return terminal immediately on exit #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1bcMax merged 1 commit into from
May 7, 2026
Merged

fix(start): return terminal immediately on exit #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 22 additions & 17 deletions src/commands/start.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,25 +529,13 @@ async function runWithInkUI(
recordLatestSessionIfEnabled(process.cwd(), agentConfig.chain);
} catch { /* telemetry is best-effort */ }

// Extract learnings from the session (async, 10s timeout, never blocks exit)
if (sessionHistory && sessionHistory.length >= 4) {
try {
const { extractLearnings } = await import('../learnings/extractor.js');
const { extractBrainEntities } = await import('../brain/extract.js');
const { ModelClient } = await import('../agent/llm.js');
const client = new ModelClient({ apiUrl: agentConfig.apiUrl, chain: agentConfig.chain });
const sid = `session-${new Date().toISOString()}`;
await Promise.race([
Promise.all([
extractLearnings(sessionHistory, sid, client),
extractBrainEntities(sessionHistory, sid, client),
]),
new Promise(resolve => setTimeout(resolve, 15_000)),
]);
} catch { /* extraction is best-effort */ }
// Optional post-session learning extraction. Disabled by default because any
// network-backed background promise can keep Node alive after the UI exits.
if (process.env.FRANKLIN_EXTRACT_ON_EXIT === '1') {
runExitBackgroundTasks(sessionHistory, agentConfig).catch(() => {});
}

await disconnectMcpServers();
disconnectMcpServers().catch(() => {});

// Session summary — delta vs. snapshot at session start
try {
Expand All @@ -565,6 +553,23 @@ async function runWithInkUI(
console.log(chalk.dim('\nGoodbye.\n'));
}

async function runExitBackgroundTasks(
sessionHistory: Dialogue[] | undefined,
agentConfig: AgentConfig,
): Promise<void> {
if (!sessionHistory || sessionHistory.length < 4) return;

const { extractLearnings } = await import('../learnings/extractor.js');
const { extractBrainEntities } = await import('../brain/extract.js');
const { ModelClient } = await import('../agent/llm.js');
const client = new ModelClient({ apiUrl: agentConfig.apiUrl, chain: agentConfig.chain });
const sid = `session-${new Date().toISOString()}`;
await Promise.all([
extractLearnings(sessionHistory, sid, client),
extractBrainEntities(sessionHistory, sid, client),
]);
}

// ─── Basic readline UI (piped input) ───────────────────────────────────────

async function runWithBasicUI(
Expand Down
Loading