Open
Conversation
- Implemented Page model with pagination attributes including pageSize, totalElements, totalPages, and pageNumber. - Added SipConnectionMetadata model to encapsulate SIP connection details such as ipAddress, port, credentials, and uuiHeader. - Created SipCredentials model for managing SIP authentication with username and password fields. - Each model includes methods for JSON serialization/deserialization and validation. - Introduced support for additional undeclared properties in each model.
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
- Updated CreateEndpointResponse to use CreateEndpointResponseData, Error, and Link classes. - Refactored EndpointResponse, ErrorResponse, and ListEndpointsResponse to replace Error1 and Link1 with Error and Link. - Added CreateEndpointResponseData class with properties and validation methods. - Improved documentation for InboundCallback, LookupResult, MachineDetectionConfiguration, MessageRequest, RbmOpenUrlEnum, RbmWebViewEnum, and StatusCallback. - Created new markdown documentation for CreateEndpointResponseData.
…into brtc-java-sdk
…plify unauthorized exception handling
ckoegel
reviewed
Mar 24, 2026
Contributor
|
This is missing the BXML verbs and tests for them as well |
- Add Connect and Endpoint BXML verbs with tests, registered in Bxml and Response - Create EndpointsApi unit/mock test following existing API test patterns - Add missing model unit tests: CreateWebRtcConnectionRequest, Device, DeviceStatusEnum, ErrorResponse, Page, SipConnectionMetadata, SipCredentials - Rename smoke test methods to operationId format (createEndpointTest, etc.) - Use builder-style field initialization instead of setters - Replace notNullValue()/hasProperty() assertions with direct field assertions - Simplify list assertions to check first element directly - Remove unnecessary filter-by-type test Generated from Claude9 with Claude Code Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Use BW_CLIENT_ID and BW_CLIENT_SECRET from environment variables instead of hardcoded fake credentials, matching the pattern used by CallsApiTest and other unit tests. The OAuth token request hits the real auth server before reaching Prism, so fake credentials cause all 5 tests to fail with invalid_client errors. Generated from Claude9 with Claude Code Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add connectionMetadata field test to CreateWebRtcConnectionRequestTest - Add data field test to ErrorResponseTest - Add tag and devices assertions to unit createEndpointTest and getEndpointTest - Add tag and page assertions to unit listEndpointsTest - Add links, page, and tag assertions to smoke listEndpointsTest - Create standalone EndpointVerbTest for Endpoint BXML verb - Add connectCallbackFallbackUrl, fallbackUsername, fallbackPassword tests to ConnectVerbTest Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The endpoint is created without a tag, so getTag() returns null on listed endpoints. Use anyOf(nullValue(), instanceOf(String.class)) instead of a strict instanceOf check. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Renamed shouldThrow* methods to follow the existing *Test pattern used by all other test methods in the file and repo. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add equalTo assertions alongside existing instanceOf checks in 12 model test files to verify actual field values, not just types. Store OffsetDateTime values in static final constants for timestamp assertions. Update ErrorResponseTest to use nullValue() matcher instead of == null. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.