fix(ci): move CLI acceptance test timeout from job to step#23205
Merged
Conversation
A job-level timeout-minutes makes the job conclusion `cancelled` on expiry, and both Slack notification steps gate on `success()` or `failure()` — neither of which is true for a cancellation. As a result, when the acceptance test hung past 30 minutes the workflow was silently killed with no notification. A step-level timeout-minutes makes the step conclusion `failure` instead, so the existing failure notification fires. Real cancellations (manual cancel, superseded-by-newer-run) still come through as `cancelled` and remain silent, which is the desired behavior for those cases.
vezenovm
approved these changes
May 12, 2026
AztecBot
pushed a commit
that referenced
this pull request
May 12, 2026
Collaborator
|
✅ Successfully backported to backport-to-v4-next-staging #23198. |
This was referenced May 12, 2026
AztecBot
added a commit
that referenced
this pull request
May 13, 2026
BEGIN_COMMIT_OVERRIDE chore: kv store test fully on vitest (#23096) chore: backport kv-store vitest migration (#23096) to v4-next (#23185) test: add noir tests for get_note_hash_membership_witness (#23190) fix(aztec-up): explicit exit in CLI acceptance test harness (#23200) refactor(pxe): batch nullifier sync across scopes (#23129) refactor(pxe): backport batch nullifier sync across scopes (#23129) to v4-next (#23208) fix(ci): revert ci-compat-e2e to AWS access keys (#23211) test: drop event_logs from compat matrix and loosen avm_simulator assertion regex (#23193) fix(aztec-up): install manifest-pinned Node version instead of LTS (#23201) fix(ci): move CLI acceptance test timeout from job to step (#23205) END_COMMIT_OVERRIDE
rangozd
pushed a commit
to rangozd/aztec-packages
that referenced
this pull request
May 16, 2026
BEGIN_COMMIT_OVERRIDE fix(aztec-up): install manifest-pinned Node version instead of LTS (AztecProtocol#23201) fix(ci): move CLI acceptance test timeout from job to step (AztecProtocol#23205) feat: package sqlite kv-store backend for stricter browser envs (AztecProtocol#23089) fix(pxe): sync target contract before cross-contract utility call (AztecProtocol#23225) fix(ci): swap slack_notify args in CLI acceptance test (AztecProtocol#23241) feat: optimize get next app tag as sender (AztecProtocol#23239) chore(aztec-nr): mark emit_event_in_public as #[inline_never] to shrink public dispatch (AztecProtocol#23161) chore: better encrypted sqlite ergonomics (AztecProtocol#23231) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the Aztec CLI Acceptance Test workflow hung past its 30-minute limit (example run), nothing landed in
#team-fairies. The job was killed but no Slack notification fired.Why
The two Slack steps gate on:
timeout-minutesat the job level makes the conclusioncancelledon expiry.success()is false (a step was cancelled), andfailure()is also false (cancelled ≠ failed). Both notification steps get skipped.timeout-minutesat the step level makes the step's conclusionfailureinstead — which the existingfailure()-gated notify already handles.Manual cancellations and "superseded by newer run" still come through as
cancelledand stay silent — that's the desired behavior for those cases; we don't want to ping the channel every time someone re-runs the workflow.