test: drop event_logs from compat matrix and loosen avm_simulator assertion regex#23193
Merged
benesjan merged 3 commits intoMay 12, 2026
Merged
Conversation
AztecBot
added
ci-draft
benesjan
previously approved these changes
May 12, 2026
benesjan
added
the
ci-compat-e2e
benesjan
dismissed
their stale review
Looks like just removing e2e_avm_simulator from tests was incorrect as it seems like a real issue with error enriching
Accept either 'not_true == true' (older nargo) or 'assert(not_true == true, "This assertion should fail!")' (post-#22911) in the public-error enrichment test. Drops the avm_simulator exclusion from compat_test_cmds added in the prior commit; only event_logs remains excluded (legacy artifacts don't have deliver_squashed_and_surviving_notes).
AztecBot
changed the title
AztecBot
added a commit
that referenced
this pull request
May 13, 2026
BEGIN_COMMIT_OVERRIDE chore: kv store test fully on vitest (#23096) chore: backport kv-store vitest migration (#23096) to v4-next (#23185) test: add noir tests for get_note_hash_membership_witness (#23190) fix(aztec-up): explicit exit in CLI acceptance test harness (#23200) refactor(pxe): batch nullifier sync across scopes (#23129) refactor(pxe): backport batch nullifier sync across scopes (#23129) to v4-next (#23208) fix(ci): revert ci-compat-e2e to AWS access keys (#23211) test: drop event_logs from compat matrix and loosen avm_simulator assertion regex (#23193) fix(aztec-up): install manifest-pinned Node version instead of LTS (#23201) fix(ci): move CLI acceptance test timeout from job to step (#23205) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Compat-e2e regressed on
v4.3.0-nightly.20260512-1(https://github.com/AztecProtocol/aztec-packages/actions/runs/25731562906). After review with Jan and David, the two failing tests need different treatments — the PXE error enrichment itself is not broken; this is purely test-vs-old-artifact text drift.What this PR does
e2e_event_logs.test.ts: drop from the compat-e2e matrix. The newtagging cache reconciliation against kernel squashingtest added in PR fix: dropped tagging indices no longer cause a pxe crash on sync #23044 callsTestLog::deliver_squashed_and_surviving_notes, a method that does not exist in legacy 4.2.x artifacts. There is no reasonable backwards-compat coverage here without backporting the contract method itself.e2e_avm_simulator.test.ts: keep it in the compat-e2e matrix and loosen the assertion-message regex to accept either the older or the newer assertion-span form:'not_true == true''assert(not_true == true, "This assertion should fail!")'The regex becomes
/Assertion failed: This assertion should fail!.*not_true == true/, which matches both shapes and still rejects unrelated assertions. The test continues to validate the PXE's public-error enrichment pipeline (assertion decode + opcode→source resolution) against legacy artifacts — which is the actually-valuable coverage David flagged in the team-fairies thread.Why not exclude
avm_simulatortoo?David pointed out that this case is the only public-error-enrichment test we have, and the enrichment code path is genuinely worth keeping under compat watch. Verified manually that enrichment runs correctly against legacy 4.2.x artifacts (paths, line/col, function names, assertion message all resolve); the only thing that differed was the locationText span granularity that nargo bakes into the artifact at compile time. Loosening the regex preserves the coverage without breaking on the legacy span shape.
Test plan
node -e '/Assertion failed: This assertion should fail!.*not_true == true/.test(…)'matches both old and new forms, rejects unrelated assertions.bash -c 'shopt -s extglob; ls src/e2e_!(block_building|prover_*|kernelless_simulation|event_logs).test.ts'fromyarn-project/end-to-endresolves to 49 files (was 48 whenavm_simulatorwas also excluded),event_logscorrectly absent.continue-on-errorfor nightlies — next nightly should be green onci-compat-e2eonce this lands.A forward-port of the regex loosening to
nextis also worthwhile (same file, identical strict regex there today), but mainlinenextdoesn't run compat-e2e so it isn't blocking; can ship as a follow-up.