fix(validator): include proposed checkpoint out-hashes when validating checkpoint proposals#23119
Open
spalladino wants to merge 2 commits intospl/override-full-checkpoint-data-on-l1from
Open
Conversation
…in validators The proposer-side fix from #23110 (parent checkpointOutHash splice under pipelining) was inlined as a private method on `CheckpointProposalJob`. The validator's block re-execution and checkpoint-proposal validation paths in `proposal_handler.ts` compute the same `previousCheckpointOutHashes` list through the same archiver-driven query, so they have the same off-by-one window: if the parent cp lands on L1 between when the validator pulls and when it re-derives, only the proposer would carry the spliced parent and attestations would mismatch. Extract the proposer's logic into a shared `getPreviousCheckpointOutHashes` helper in `stdlib/src/checkpoint/`. The helper accepts the proposer's already-loaded `proposedCheckpointData` directly, and falls back on `L2BlockSource.getProposedCheckpointData(...)` for callers that don't have it on hand (validator). Wire the helper into the proposer (replacing the private method) and into both validator sites. Add a few diagnostics that helped pinpoint this class of bug: - `prover-node-publisher.ts`: when the L1-recomputed `RootRollupPublicInputs` vector mismatches the prover's, decode the differing indices into labels (`previousArchiveRoot`, `endArchiveRoot`, `outHash`, `checkpointHeaderHashes[i]`, `fees[i].recipient/value`, `constants.*`, `blobPublicInputs[*]`), fetch the L1 `CheckpointLog` for any mismatching `checkpointHeaderHashes[i]`, and emit a structured error log alongside the throw — much easier to triage than the previous opaque dump. - `BlockRollupPublicInputs.toInspect()` and `CheckpointRollupPublicInputs.toInspect()` to keep per-stage orchestrator debug logs short. - Per-stage debug logs in the orchestrator (block-root, block-merge, checkpoint-root) consume the new `toInspect()` outputs. - Lightweight checkpoint builder logs `headerHash` and the size of `previousCheckpointOutHashes` at debug. - Epoch proving job's per-checkpoint start log trimmed to the fields that are actually useful for cross-comparison.
spalladino
force-pushed
the
spl/diagnostics-out-hash-helper
branch
from
8bb0f23 to
b507d54
Compare
Mirrors the pipelining toggles applied to the rest of the p2p e2e suite (`enableProposerPipelining: true`, `inboxLag: 2`, `minTxsPerBlock: 0`) plus the test-side adjustments needed to keep cross-chain assertions deterministic (`waitForL1ToL2MessageReady` instead of the older `waitForL1ToL2MessageSeen`, longer per-test jest timeout). Intentionally does NOT add the `EpochTestSettler` cheat-code workaround that previously masked the `Root rollup public inputs mismatch`; the helper-based fix earlier in this PR is what unblocks add_rollup under pipelining.
spalladino
force-pushed
the
spl/diagnostics-out-hash-helper
branch
from
b507d54 to
3ee9452
Compare
spalladino
changed the title
Collaborator
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract the fix for
outHashes added in #23073 in the proposer so that it can be reused in validators as well. Enables pipelining onadd_rollupe2e p2p test, which was failing because of this bug. Also adds a bunch of logging, which was needed to track down the issue.Builds on top of #23073