Skip to content

test: skip tx_stats_bench 10 TPS sub-test on merge-train/fairies#23101

Closed
vezenovm wants to merge 1 commit into
merge-train/fairiesfrom
mv/skip-tx-stats-bench-10tps-fairies
Closed

test: skip tx_stats_bench 10 TPS sub-test on merge-train/fairies#23101
vezenovm wants to merge 1 commit into
merge-train/fairiesfrom
mv/skip-tx-stats-bench-10tps-fairies

Conversation

@vezenovm
Copy link
Copy Markdown
Contributor

@vezenovm vezenovm commented May 8, 2026

Motivation

Cherry-pick of #23092 onto merge-train/fairies. The same verifies transactions at 10 TPS flake in tx_stats_bench.test.ts:268 that #23092 skips on merge-train/spartan is now blocking PRs based on merge-train/fairies (e.g. seen on the mv/f-637-public-self-creator branch in ci-full):

● transaction benchmarks › verifies transactions at 10 TPS
  expect(received).toBe(expected) // Object.is equality
  Expected: true
  Received: false
    at toBe (bench/tx_stats_bench.test.ts:268:69)

#23092 has the full analysis: under 8x parallel IVC verifications (each spawning a bb subprocess via the bb.js NativeUnixSocket backend introduced in #21564), at least one verification intermittently returns valid:false. None of the merge-train commits triggering the failure touch the bb-prover IVC verifier path.

Notes

  • Re-enable it.skipit once the bb.js backend's concurrent-verifier interaction (withVerifierInstance lifecycle) is hardened.

Cherry-pick of #23092 onto merge-train/fairies. Same flake (`verifies
transactions at 10 TPS` in `tx_stats_bench.test.ts:268`) is now blocking
PRs based on this train; see #23092 for the full analysis (bb.js
NativeUnixSocket backend under 8x parallel IVC verifications
intermittently returning `valid:false`).

Skipping at sub-test granularity keeps the other three serial sub-tests
emitting their compression and single-tx verification metrics; only the
IVC-verifier-under-concurrency metrics are dropped. The
`.test_patterns.yml` flake-retry entry from #23083 stays in place.
@vezenovm
Copy link
Copy Markdown
Contributor Author

vezenovm commented May 8, 2026

This unblocks #23062 and ci-full on merge-train/fairies more generally. We can also wait for merge-train/spartan to be fixed up. But then we have to wait for that to be synced into next so we can updates the fairies branch. What do you think @nchamo?

@vezenovm vezenovm requested a review from nchamo May 8, 2026 16:27
Copy link
Copy Markdown
Contributor

@nchamo nchamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not do this now, and see how we can apply the same fix they apply. Otherwise, we would be turning off their test when this is merged to next

@vezenovm
Copy link
Copy Markdown
Contributor Author

vezenovm commented May 8, 2026

Closing, we will wait for merge-train/spartan to resolve the test

@vezenovm vezenovm closed this May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants