test: skip tx_stats_bench 10 TPS sub-test on merge-train/fairies#23101
Closed
vezenovm wants to merge 1 commit into
Closed
test: skip tx_stats_bench 10 TPS sub-test on merge-train/fairies#23101vezenovm wants to merge 1 commit into
vezenovm wants to merge 1 commit into
Conversation
Cherry-pick of #23092 onto merge-train/fairies. Same flake (`verifies transactions at 10 TPS` in `tx_stats_bench.test.ts:268`) is now blocking PRs based on this train; see #23092 for the full analysis (bb.js NativeUnixSocket backend under 8x parallel IVC verifications intermittently returning `valid:false`). Skipping at sub-test granularity keeps the other three serial sub-tests emitting their compression and single-tx verification metrics; only the IVC-verifier-under-concurrency metrics are dropped. The `.test_patterns.yml` flake-retry entry from #23083 stays in place.
Contributor
Author
nchamo
reviewed
May 8, 2026
Contributor
nchamo
left a comment
There was a problem hiding this comment.
Let's not do this now, and see how we can apply the same fix they apply. Otherwise, we would be turning off their test when this is merged to next
Contributor
Author
|
Closing, we will wait for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Cherry-pick of #23092 onto
merge-train/fairies. The sameverifies transactions at 10 TPSflake intx_stats_bench.test.ts:268that #23092 skips onmerge-train/spartanis now blocking PRs based onmerge-train/fairies(e.g. seen on themv/f-637-public-self-creatorbranch inci-full):#23092 has the full analysis: under 8x parallel IVC verifications (each spawning a bb subprocess via the bb.js
NativeUnixSocketbackend introduced in #21564), at least one verification intermittently returnsvalid:false. None of the merge-train commits triggering the failure touch the bb-prover IVC verifier path.Notes
it.skip→itonce the bb.js backend's concurrent-verifier interaction (withVerifierInstancelifecycle) is hardened.