Conversation
- Toggle to enable while in postspageview via Page Settings or regular Settings screen - While scrolling, top and bottom bars will scroll away. Top bars will scroll up, bottom bars will scroll down. - When reaching the bottom of the page, bars will scroll back into position
…om of the scroll. Previously bars would scroll back into place but this would only succeed in reaching their destination position about 80% of the time. Now the bars will fade back into view already in position. Sliding behaviour still applies to disappearing at the top of the scroll and returning when not at the bottom.
dead Awful.scrollToPostWithID JS hook
- Replace empty if #available(iOS 26.0, *) {} else branches with
if #unavailable(iOS 26.0) in PostsPageViewController toolbar items
- Delete redundant exitImmersiveMode() and resetNavigationBarState()
wrappers; the manager already resets transforms and never hides
the nav bar, so the extra reset and isNavigationBarHidden branch
were unreachable
- Inline single-use safeAreaGradientView computed property in
PostsPageView
- Drop obvious "Configure the immersive mode manager" comment and
trailing whitespace in Settings.swift
Cache scroll-driven nav bar appearance resources
updateNavigationBarTintForScrollProgress rebuilds a
UINavigationBarAppearance on every scroll delta above 0.005. Cache
the expensive pieces so scroll-driven updates don't re-allocate or
redraw identical resources each frame.
- Cache the gradient background image by color; invalidate in
themeDidChange. Replaces a UIGraphicsImageRenderer + CGGradient
draw on every mid-scroll event.
- Lazy-cache the two back-indicator variants (template and
.label-tinted .alwaysOriginal). The .label variant stays dynamic
because .label is a system-dynamic color, so no invalidation
needed on trait changes.
- Snap progress to 0 or 1 outside the atTop/fullyScrolled thresholds
before the delta-gate check, so oscillations around the boundaries
stop triggering redundant appearance rebuilds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Ideally merge this one last out of all the current PRs