Check that author variable is of the expected type#7838
Open
Check that author variable is of the expected type#7838
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a warning that occurs when attempting to access the display_name property on a boolean value instead of a WP_User object. The issue was reported when using the Sensei plugin with Safety Net.
Key changes:
- Updated
get_term_author()documentation to accurately reflect that it can returnWP_User|false - Added type check to ensure
$authoris aWP_Userinstance before accessing its properties
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| includes/class-sensei-modules.php | Updated function documentation and added type safety check before accessing $author->display_name property |
| changelog/fix-variable-type-mismatch | Added changelog entry documenting the fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue reported by Team51:
Proposed Changes
Check that
$authoris aWP_Userobject before trying to access thedisplay_nameproperty.Though I wasn't able to reproduce the reported issue, this seems like a safe change.
Pre-Merge Checklist