Skip to content

Make developer app address lookups case-insensitive #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rickyrombo merged 3 commits into from
Apr 13, 2026
+44 −2
Merged

Make developer app address lookups case-insensitive #762

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
92c0bb0
Make developer app address lookups case-insensitive
rickyrombo Apr 10, 2026
09d7729
Normalize address to lowercase in Go, revert lower() from SQL queries
Copilot Apr 10, 2026
3134346
Remove duplicate test functions in developer apps test
rickyrombo Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions api/dbv1/get_developer_apps.sql.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions api/dbv1/queries/get_developer_apps.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ SELECT
FROM developer_apps da
LEFT JOIN oauth_redirect_uris oau ON oau.client_id = da.address
WHERE
(da.user_id = @user_id OR da.address = @address)
(da.user_id = @user_id OR lower(da.address) = lower(@address))
Comment thread
rickyrombo marked this conversation as resolved.
Outdated
Comment thread
rickyrombo marked this conversation as resolved.
Outdated
AND da.is_current = true
AND da.is_delete = false
GROUP BY da.address, da.user_id, da.name, da.description, da.image_url, da.created_at
Expand All @@ -27,7 +27,7 @@ SELECT
FROM developer_apps
LEFT JOIN grants ON grants.grantee_address = developer_apps.address
WHERE
(grants.user_id = @user_id OR developer_apps.address = @address)
(grants.user_id = @user_id OR lower(developer_apps.address) = lower(@address))
Comment thread
rickyrombo marked this conversation as resolved.
Outdated
AND grants.is_revoked = false
AND grants.is_current = true
AND developer_apps.is_current = true
Expand Down
Loading