[PWGLF] Added process function for closure in MCGen#15703
[PWGLF] Added process function for closure in MCGen#15703romainschotter merged 2 commits intoAliceO2Group:masterfrom
Conversation
scannito
requested review from
alibuild,
ercolessi,
lhusova,
mpuccio,
omvazque,
romainschotter and
skundu692
as code owners
|
O2 linter results: ❌ 1 errors, |
There was a problem hiding this comment.
Pull request overview
Adds an MCGen “closure” processing path to phiStrangeCorrelation by introducing lightweight per-event/per-particle containers and a multiplicity-binned mixed-event buffer, then filling new Δy vs Δφ closure histograms for Φ–K0S and Φ–π in same-event (SE) and mixed-event (ME) modes.
Changes:
- Add
MiniParticle/MiniEventstructures plus astd::vector<std::deque<MiniEvent>>event-mixing buffer (binned in multiplicity). - Add
getCentBin()helper and a newprocessMCGenClosure()that fills new MCGen closure SE/ME histograms. - Change defaults for
analysisMode,selectK0sInSigRegion, andselectPionInSigRegion.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
| } | ||
|
|
||
| eventBuffer.resize(binsMult->size() - 1); | ||
| } |
There was a problem hiding this comment.
eventBuffer.resize(binsMult->size() - 1) can underflow if binsMult is misconfigured with < 2 entries (size_t wraparound), potentially attempting a huge allocation. Add a guard/check in init() (and ideally LOG(fatal)/throw) to enforce at least 2 bin edges before resizing.
| /*void processMCGenClosureSE(MCCollisions::iterator const& mcCollision, aod::McParticles const& mcParticles) | ||
| { | ||
| float multiplicity = mcCollision.centFT0M(); | ||
|
|
||
| std::vector<int64_t> phiIndices; |
There was a problem hiding this comment.
A large block of fully commented-out code (processMCGenClosureSE/processMCGenClosureME) is left in the task. This makes the file harder to maintain/review and can easily drift out of sync. Please remove it (or move it to a separate commit/branch) now that processMCGenClosure replaces it.
No description provided.