Skip to content

[PWGLF] Table producer for photonDe correlation study#15509

Draft
arvindkhuntia wants to merge 10 commits intoAliceO2Group:masterfrom
arvindkhuntia:master
Draft

[PWGLF] Table producer for photonDe correlation study#15509
arvindkhuntia wants to merge 10 commits intoAliceO2Group:masterfrom
arvindkhuntia:master

Conversation

@arvindkhuntia
Copy link
Copy Markdown
Contributor

No description provided.

Please consider the following formatting changes to AliceO2Group#15509
@maciacco maciacco marked this pull request as draft March 24, 2026 18:22
@alibuild
Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 9dd013d at 2026-03-24 20:10:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/15509-slc9_x86-64/0/PWGLF/TableProducer/Nuspex/photonDeuteron.cxx:20:10: fatal error: Common/DataModel/PIDResponse.h: No such file or directory
ninja: build stopped: subcommand failed.

Full log here.

@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented Mar 24, 2026

@arvindkhuntia How did you test your changes? They don't compile.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2026

O2 linter results: ❌ 1 errors, ⚠️ 9 warnings, 🔕 0 disabled

#ifndef PWGLF_DATAMODEL_LFPHOTONDEUTERONTABLES_H_
#define PWGLF_DATAMODEL_LFPHOTONDEUTERONTABLES_H_

#include "Framework/AnalysisDataModel.h"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do you use the header?

Comment on lines +24 to +27
#include "Framework/ASoAHelpers.h"
#include "Framework/AnalysisTask.h"
#include "Framework/HistogramRegistry.h"
#include "Framework/runDataProcessing.h"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong format

const auto& deuteron = tracks.iteratorAt(deuteronIdx);

// Calculate angular correlations
float deltaPhi = RecoDecay::constrainAngle(photon.phi() - deuteron.phi(), -0.5 * M_PI);
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use M_PI.


if (v0.isPhotonTPConly()) {
photonIndices.push_back(v0.index());
LOGF(debug, "[main] global index photon: %d v0 id: %d pt %.3f", v0.globalIndex(), v0.index(), v0.pt());
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include what you use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants