Skip to content

[PWGLF] Omegahm #14279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
romainschotter merged 2 commits into from
Dec 18, 2025
+160 −90
Merged

[PWGLF] Omegahm #14279

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5faf8b0
dev: fixing mem leaks and optimising speed
lietava Dec 18, 2025
f7bb111
clang
lietava Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
250 changes: 160 additions & 90 deletions PWGLF/Tasks/Strangeness/nonPromptCascade.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
#include "ReconstructionDataFormats/Vertex.h"

#include "Math/Vector4D.h"
#include "TDatabasePDG.h"

Check failure on line 39 in PWGLF/Tasks/Strangeness/nonPromptCascade.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[pdg/database] 

Do not use TDatabasePDG directly. Use o2::constants::physics::Mass... or Service<o2::framework::O2DatabasePDG> instead.
#include "THnSparse.h"
#include "TParticlePDG.h"
#include "TTree.h"
Expand Down Expand Up @@ -144,13 +144,13 @@
if (particle.has_mothers()) {
auto mom = particle.template mothers_as<aod::McParticles>()[0];
int pdgCodeMom = mom.pdgCode();
fromBeauty = std::abs(pdgCodeMom) / 5000 == 1 || std::abs(pdgCodeMom) / 500 == 1 || std::abs(pdgCodeMom) == 5;

Check failure on line 147 in PWGLF/Tasks/Strangeness/nonPromptCascade.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[pdg/explicit-code] 

Avoid hard-coded PDG codes. Use named values from PDG_t or o2::constants::physics::Pdg instead.
fromCharm = std::abs(pdgCodeMom) / 4000 == 1 || std::abs(pdgCodeMom) / 400 == 1 || std::abs(pdgCodeMom) == 4;

Check failure on line 148 in PWGLF/Tasks/Strangeness/nonPromptCascade.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[pdg/explicit-code] 

Avoid hard-coded PDG codes. Use named values from PDG_t or o2::constants::physics::Pdg instead.
while (mom.has_mothers()) {
const auto grandma = mom.template mothers_as<aod::McParticles>()[0];
int pdgCodeGrandma = std::abs(grandma.pdgCode());
fromBeauty = fromBeauty || (pdgCodeGrandma / 5000 == 1 || pdgCodeGrandma / 500 == 1 || pdgCodeGrandma == 5);

Check failure on line 152 in PWGLF/Tasks/Strangeness/nonPromptCascade.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[pdg/explicit-code] 

Avoid hard-coded PDG codes. Use named values from PDG_t or o2::constants::physics::Pdg instead.
fromCharm = fromCharm || (pdgCodeGrandma / 4000 == 1 || pdgCodeGrandma / 400 == 1 || pdgCodeGrandma == 4);

Check failure on line 153 in PWGLF/Tasks/Strangeness/nonPromptCascade.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[pdg/explicit-code] 

Avoid hard-coded PDG codes. Use named values from PDG_t or o2::constants::physics::Pdg instead.
mom = grandma;
}
}
Expand Down Expand Up @@ -281,7 +281,7 @@
int nBinsMultFV0 = cfgMaxMultFV0;

AxisSpec multAxis = {nBinsMult, 0, cfgMaxMult, "Multiplicity FT0M"};
AxisSpec multAxisFV0 = {nBinsMultFV0, 0, cfgMaxMultFV0, "Multiplicity FT0M"};
AxisSpec multAxisFV0 = {nBinsMultFV0, 0, cfgMaxMultFV0, "Multiplicity FV0"};
AxisSpec nTracksAxis = {100, 0., 100., "NTracksGlobal"};
AxisSpec nTracksAxisMC = {100, 0., 100., "NTracksMC"};
std::vector<double> centBinning;
Expand Down Expand Up @@ -311,13 +311,13 @@
runsBinning.push_back(run);
run++;
}
AxisSpec centAxis{centBinning, "Centrality (%)"};
// AxisSpec multAxis{multBinning, "Multiplicity"};
AxisSpec centAxisFT0M{centBinning, "Centrality FT0M (%)"};
AxisSpec centAxisFV0{centBinning, "Centrality FV0 (%)"};
AxisSpec trackAxisMC{trackBinning, "NTracks MC"};
AxisSpec trackAxis{trackBinning, "NTracks Global Reco"};
AxisSpec runsAxis{runsBinning, "Run Number"};

mRegistryMults.add("hCentMultsRuns", "hCentMultsRuns", HistType::kTHnSparseF, {centAxis, multAxis, centAxis, multAxisFV0, nTracksAxis, runsAxis});
mRegistryMults.add("hCentMultsRuns", "hCentMultsRuns", HistType::kTHnSparseF, {centAxisFT0M, multAxis, centAxisFV0, multAxisFV0, nTracksAxis, runsAxis});
//
// dN/deta
//
Expand Down Expand Up @@ -558,13 +558,13 @@
if (protonTrack.mcParticle().has_mothers() && pionTrack.mcParticle().has_mothers() && bachelor.mcParticle().has_mothers()) {
if (protonTrack.mcParticle().mothersIds()[0] == pionTrack.mcParticle().mothersIds()[0]) {
const auto v0part = protonTrack.mcParticle().template mothers_first_as<aod::McParticles>();
if (std::abs(v0part.pdgCode()) == 3122 && v0part.has_mothers()) {

Check failure on line 561 in PWGLF/Tasks/Strangeness/nonPromptCascade.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[pdg/explicit-code] 

Avoid hard-coded PDG codes. Use named values from PDG_t or o2::constants::physics::Pdg instead.
const auto motherV0 = v0part.template mothers_as<aod::McParticles>()[0];
if (v0part.mothersIds()[0] == bachelor.mcParticle().mothersIds()[0]) {
if (std::abs(motherV0.pdgCode()) == 3312 || std::abs(motherV0.pdgCode()) == 3334) {

Check failure on line 564 in PWGLF/Tasks/Strangeness/nonPromptCascade.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[pdg/explicit-code] 

Avoid hard-coded PDG codes. Use named values from PDG_t or o2::constants::physics::Pdg instead.
isGoodCascade = true;

isOmega = (std::abs(motherV0.pdgCode()) == 3334);

Check failure on line 567 in PWGLF/Tasks/Strangeness/nonPromptCascade.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[pdg/explicit-code] 

Avoid hard-coded PDG codes. Use named values from PDG_t or o2::constants::physics::Pdg instead.
fromHF = isFromHF(motherV0);
mcParticleID = v0part.mothersIds()[0];
}
Expand Down Expand Up @@ -792,114 +792,184 @@
}
PROCESS_SWITCH(NonPromptCascadeTask, processCascadesData, "process cascades: Data analysis", false);

int getMCMult(aod::McParticles const& mcParticles, int mcCollId, std::vector<float>& ptMCvec)
// colls : Join<aod::Collisions, ...>
// tracks: Join<aod::Tracks, aod::McTrackLabels>
// mcCollisions: aod::McCollisions
// mcParticles : aod::McParticles

void processdNdetaMC(CollisionCandidatesRun3MC const& colls,
aod::McCollisions const& mcCollisions,
aod::McParticles const& mcParticles,
TracksWithLabel const& tracks)
{
int mult = 0;
//-------------------------------------------------------------
// MC mult for all MC coll
//--------------------------------------------------------------
std::vector<int> mcMult(mcCollisions.size(), 0);
for (auto const& mcp : mcParticles) {
if (mcp.mcCollisionId() == mcCollId) {
// multiplicity definition:
bool accept = mcp.isPhysicalPrimary();
accept = accept && (mcp.eta() < 0.5) && (mcp.eta() > -0.5);
int q = 0;
auto pdgEntry = TDatabasePDG::Instance()->GetParticle(mcp.pdgCode());
if (pdgEntry) {
q = int(std::round(pdgEntry->Charge() / 3.0));
} else {
// LOG(warn) << "No pdg assuming neutral";
}
accept = accept && (q != 0);
if (accept) {
++mult;
ptMCvec.push_back(mcp.pt());
}
int mcid = mcp.mcCollisionId();
if (mcid < 0 || mcid >= (int)mcMult.size())
continue;

// apply your primary/eta/charge definition here
if (!mcp.isPhysicalPrimary())
continue;
if (std::abs(mcp.eta()) > 0.5f)
continue;
int q = 0;
if (auto pdg = TDatabasePDG::Instance()->GetParticle(mcp.pdgCode())) {

Check failure on line 820 in PWGLF/Tasks/Strangeness/nonPromptCascade.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[pdg/database] 

Do not use TDatabasePDG directly. Use o2::constants::physics::Mass... or Service<o2::framework::O2DatabasePDG> instead.
Copy link
Copy Markdown
Collaborator

@vkucera vkucera Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you still use TDatabasePDG::Instance?

Copy link
Copy Markdown
Collaborator Author

@lietava lietava Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean ? What should I use ?

Copy link
Copy Markdown
Collaborator

@vkucera vkucera Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use Service<o2::framework::O2DatabasePDG>, as the linter suggests.

Copy link
Copy Markdown
Collaborator Author

@lietava lietava Dec 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, fix in the next pr. Thanks.

q = int(std::round(pdg->Charge() / 3.0));
}
if (q == 0)
continue;

++mcMult[mcid];
}
return mult;
}
void processdNdetaMC(CollisionCandidatesRun3MC const& colls, aod::McCollisions const& mcCollisions, aod::McParticles const& mcParticles, TracksWithLabel const& tracks)
{
// std::cout << "ProcNegMC" << std::endl;
// Map: collision index -> reco multiplicity
std::vector<int> recoMult(colls.size(), 0);

// ------------------------------------------------------------
// Build mapping: (aod::Collisions row id used by tracks.collisionId())
// -> dense index in 'colls' (0..colls.size()-1)
// We assume col.globalIndex() refers to the original aod::Collisions row.
// ------------------------------------------------------------
int maxCollRowId = -1;
for (auto const& trk : tracks) {
maxCollRowId = std::max(maxCollRowId, (int)trk.collisionId());
}
std::vector<int> collRowIdToDense(maxCollRowId + 1, -1);

int dense = 0;
for (auto const& col : colls) {
const int collRowId = col.globalIndex(); // row id in aod::Collisions
if (collRowId >= 0 && collRowId < (int)collRowIdToDense.size()) {
collRowIdToDense[collRowId] = dense;
}
++dense;
}

// ------------------------------------------------------------
// Reco multiplicity per *dense collision index in colls*
// ------------------------------------------------------------
std::vector<int> recoMultDense(colls.size(), 0);
for (auto const& trk : tracks) {
int collId = trk.collisionId();
// Here you can impose same track cuts as for MC (eta, primaries, etc.)
if (std::abs(trk.eta()) > 0.5f) {
continue;
}
++recoMult[collId];
const int collRowId = trk.collisionId();
if (collRowId < 0 || collRowId >= (int)collRowIdToDense.size()) {
continue;
}
const int dIdx = collRowIdToDense[collRowId];
if (dIdx >= 0) {
++recoMultDense[dIdx];
}
}
std::vector<int> isReco(mcParticles.size(), 0);
std::vector<int> isRecoMult(mcParticles.size(), 0);
std::vector<int> mcReconstructed(mcCollisions.size(), 0);
// std::cout << " reco cols with mc:" << colls.size() << " tracks:" << tracks.size() << " mccols:" << mcCollisions.size() << "mcParticles:" << mcParticles.size() << std::endl;
for (auto const& col : colls) {
int mcCollId = col.mcCollisionId(); // col.template mcCollision_as<aod::McCollisions>();
int collId = col.globalIndex();
// auto mc = col.mcCollision();
// int mcId = mc.globalIndex();
// std::cout << "globalIndex:" << mcId << " colID:" << mcCollId << std::endl;
std::vector<float> mcptvec;
float mult = getMCMult(mcParticles, mcCollId, mcptvec);

// ------------------------------------------------------------
// MC bookkeeping: index by ROW INDEX (0..size-1), not globalIndex()
// ------------------------------------------------------------
std::vector<char> isReco(mcParticles.size(), 0);
std::vector<float> isRecoMult(mcParticles.size(), 0.f);
std::vector<char> mcReconstructed(mcCollisions.size(), 0);

// Optional cache of MC multiplicity per MC collision
std::vector<float> mcMultCache(mcCollisions.size(), -1.f);

// ------------------------------------------------------------
// Single pass over tracks: fill RM for tracks whose collision is in colls
// ------------------------------------------------------------
for (auto const& trk : tracks) {
// Accept reco track
if (std::abs(trk.eta()) > 0.5f) {
continue;
}

// Map track's collision row id -> dense colls index
const int collRowId = trk.collisionId();
if (collRowId < 0 || collRowId >= (int)collRowIdToDense.size()) {
continue;
}
const int dIdx = collRowIdToDense[collRowId];
if (dIdx < 0) {
continue; // this track's collision is not in our 'colls' view
}

// Get the collision row (dense index in colls view)
auto col = colls.rawIteratorAt(dIdx);

// MC collision id (row index in aod::McCollisions)
const int mcCollId = col.mcCollisionId();
if (mcCollId < 0 || mcCollId >= (int)mcCollisions.size()) {
continue;
}
mcReconstructed[mcCollId] = 1;
for (auto const& trk : tracks) {
int mcPid = trk.mcParticleId(); // depends on your label table
if (mcPid >= 0 && mcPid < (int)mcParticles.size()) {
isReco[mcPid] = 1;
isRecoMult[mcPid] = mult;
} else {
continue;
}
if (trk.collisionId() != collId) {
continue; // different event
}
auto mcPar = mcParticles.rawIteratorAt(mcPid);
// Apply same acceptance as in MC multiplicity
if (!mcPar.isPhysicalPrimary()) {
continue;
}
if (std::abs(mcPar.eta()) > 0.5f) {
continue;
}
int q = 0;
auto pdgEntry = TDatabasePDG::Instance()->GetParticle(mcPar.pdgCode());
if (pdgEntry) {
q = int(std::round(pdgEntry->Charge() / 3.0));
}
if (q == 0) {
continue;
}
// float multReco = recoMult[collId];
float multReco = col.multNTracksGlobal();
float ptReco = trk.pt();
float ptMC = mcPar.pt();
mRegistrydNdeta.fill(HIST("hdNdetaRM/hdNdetaRM"), mult, multReco, ptMC, ptReco);

// MC particle id (row index in aod::McParticles)
const int mcPid = trk.mcParticleId();
if (mcPid < 0 || mcPid >= (int)mcParticles.size()) {
continue;
}

// mRegistry.fill(HIST("hNTracksMCVsTracksReco"), mult, col.multNTracksGlobal());
// MC multiplicity for that MC collision (cache)
float mult = mcMultCache[mcCollId];
if (mult < 0.f) {
std::vector<float> tmp;
mult = mcMult[mcCollId];
mcMultCache[mcCollId] = mult;
}

auto mcPar = mcParticles.rawIteratorAt(mcPid);

// Apply the same acceptance as in MC multiplicity definition
if (!mcPar.isPhysicalPrimary()) {
continue;
}
if (std::abs(mcPar.eta()) > 0.5f) {
continue;
}

int q = 0;
if (auto pdgEntry = TDatabasePDG::Instance()->GetParticle(mcPar.pdgCode())) {

Check failure on line 931 in PWGLF/Tasks/Strangeness/nonPromptCascade.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[pdg/database] 

Do not use TDatabasePDG directly. Use o2::constants::physics::Mass... or Service<o2::framework::O2DatabasePDG> instead.
q = int(std::round(pdgEntry->Charge() / 3.0));
}
if (q == 0) {
continue;
}

// Mark reconstructed MC particle (now that it truly passed & matched)
isReco[mcPid] = 1;
isRecoMult[mcPid] = mult;

const float multReco = col.multNTracksGlobal(); // or recoMultDense[dIdx]
const float ptReco = trk.pt();
const float ptMC = mcPar.pt();

mRegistrydNdeta.fill(HIST("hdNdetaRM/hdNdetaRM"), mult, multReco, ptMC, ptReco);
}
// count mc particles with no reco tracks
for (auto const& mcp : mcParticles) {
int mcPidG = mcp.globalIndex();
// std::cout << "mcPidG:" << mcPidG << std::endl;
if (!isReco[mcPidG]) {
mRegistrydNdeta.fill(HIST("hdNdetaRM/hdNdetaRMNotInRecoTrk"), isRecoMult[mcPidG], mcp.pt());

// ------------------------------------------------------------
// MC particles with no reco track (iterate by row index)
// ------------------------------------------------------------
for (int pid = 0; pid < (int)mcParticles.size(); ++pid) {
if (!isReco[pid]) {
auto mcp = mcParticles.rawIteratorAt(pid);
mRegistrydNdeta.fill(HIST("hdNdetaRM/hdNdetaRMNotInRecoTrk"), isRecoMult[pid], mcp.pt());
}
}
// count unreconstructed mc collisions
for (auto const& mc : mcCollisions) {
int gindex = mc.globalIndex();
// std::cout << "mc globalIndex:" << gindex << std::endl;
if (!mcReconstructed[gindex]) {

// ------------------------------------------------------------
// Unreconstructed MC collisions (iterate by row index)
// ------------------------------------------------------------
for (int mcid = 0; mcid < (int)mcCollisions.size(); ++mcid) {
if (!mcReconstructed[mcid]) {
std::vector<float> mcptvec;
int mult = getMCMult(mcParticles, gindex, mcptvec);
// std::cout << "===> unreconstructed:" << mult << std::endl;
const int mult = mcMult[mcid];
for (auto const& pt : mcptvec) {
Copy link
Copy Markdown
Collaborator

@vkucera vkucera Apr 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This loop never runs because mcptvec is always empty.

mRegistrydNdeta.fill(HIST("hdNdetaRM/hdNdetaRMNotInRecoCol"), mult, pt);
}
}
}
}

PROCESS_SWITCH(NonPromptCascadeTask, processdNdetaMC, "process mc dN/deta", false);
};

Expand Down
Loading