Skip to content

[O2B-1577] Rename include.byName filter to permittedNonPhysicsNames#2128

Open
NarrowsProjects wants to merge 1 commit intomainfrom
improv/O2B-1577/Rename-the-include.byName-filter-in-data-passes-overview-model-to-includeName
Open

[O2B-1577] Rename include.byName filter to permittedNonPhysicsNames#2128
NarrowsProjects wants to merge 1 commit intomainfrom
improv/O2B-1577/Rename-the-include.byName-filter-in-data-passes-overview-model-to-includeName

Conversation

@NarrowsProjects
Copy link
Copy Markdown
Collaborator

@NarrowsProjects NarrowsProjects commented Apr 9, 2026

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • N/A

Notable changes for developers:

  • The include.byName filter is now called permittedNonPhysicsNames
  • The first ~30 lines of code in datapassService.getAll have been refactored for readability

Changes made to the database:

  • N/A

@NarrowsProjects NarrowsProjects self-assigned this Apr 9, 2026
@NarrowsProjects NarrowsProjects requested a review from graduta as a code owner April 9, 2026 14:06
@NarrowsProjects NarrowsProjects added backend javascript Pull requests that update Javascript code labels Apr 9, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2026

Codecov Report

❌ Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.50%. Comparing base (1333378) to head (893ed68).

Files with missing lines Patch % Lines
...ataPasses/ActiveColumns/dataPassesActiveColumns.js 0.00% 1 Missing ⚠️
lib/server/controllers/dataPasses.controller.js 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2128      +/-   ##
==========================================
- Coverage   45.50%   45.50%   -0.01%     
==========================================
  Files        1044     1044              
  Lines       17353    17350       -3     
  Branches     3149     3148       -1     
==========================================
- Hits         7897     7895       -2     
+ Misses       9456     9455       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend frontend javascript Pull requests that update Javascript code

Development

Successfully merging this pull request may close these issues.

1 participant