Update sockethub integration for latest API

[silverbucket]

Summary

• Replace CDN-loaded sockethub scripts with @sockethub/client@^5.0.0-alpha.12 and socket.io-client npm packages
• Adapt to the new client lifecycle: ready() initialization, contextFor() for dynamic @context arrays, platform schema validation
• Use @context arrays from server registry instead of the context string property on outgoing messages
• Wrap actor and target as objects with id and type properties
• IRC channel IDs now use channel@hostname format (was hostname/channel)
• Add completed, failed, and client_error event listeners for proper job status tracking
• Resolve platform from @context for incoming message routing via platformForMessage()
• Refactor transferMeMessage to accept channel object directly (consistent with transferMessage)
• Remove deprecated observe handler and ActivityStreams.Object.create() pre-registration calls
• Fix pre-existing XMPP log type bug in credential error handling

Test plan

• All unit tests pass (101/101)
• Production build succeeds
• XMPP connect, join, send, and receive verified manually
• IRC connect, join, send, and receive
• Verify configure-sockethub screen shows when server is unreachable

[Copilot]

Pull request overview

Updates Hyperchannel’s Sockethub integration to use the latest client API shipped via npm packages, and adapts message/job handling to the new @context/lifecycle model.

Changes:

• Replaces CDN-loaded Sockethub client usage with @sockethub/client + socket.io-client, and updates initialization (ready()).
• Updates IRC/XMPP transport services to emit jobs using @context arrays and structured actor/target objects; updates IRC channel ID format.
• Adds handling for Sockethub job lifecycle events (completed, failed, client_error) and routes incoming messages based on @context.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
tests/unit/services/sockethub-xmpp-test.js	Updates unit tests to reflect the new @context job format and removes pre-registration assumptions.
package.json	Adds @sockethub/client and socket.io-client dependencies.
package-lock.json	Locks new Sockethub and Socket.IO client dependency graph.
app/services/sockethub.js	Migrates to npm-based Sockethub client initialization and adds contextFor() / platformForMessage() helpers.
app/services/sockethub-xmpp.js	Refactors XMPP job payloads to the new schema (@context, structured actor/target).
app/services/sockethub-irc.js	Refactors IRC job payloads to the new schema and adapts to the new IRC channel ID format.
app/services/coms.js	Adds job lifecycle listeners and routes incoming messages using platform derived from @context.
app/models/base_channel.js	Updates IRC Sockethub channel ID format to channel@hostname.
app/controllers/base_channel.js	Updates /me command path to use the refactored transferMeMessage signature.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[raucao]

Why do we need this separately? Isn't it part of the Sockethub client anymore?

[silverbucket]

It was never bundled in the client, it was (and still is) served by sockethub server. So you import sockethub and socket.io and then pass in an instance of socket.io when creating the sockethub client.

The reason I added these as deps rather than loading from the server, was so we could have all the benefits of typing etc. I am not sure what's the best approach, so if you have suggestions we can change it. I just like the idea that we have more help and warnings up front when using the client (especially now as there will be schema registration and validation that should be happening at the client side so we could theoretically see syntax issues as we're writing the AS objects -- I havent tested this explicitly yet).

[raucao]

Nice!

This seems to be working well for XMPP, but there's a bug with IRC presence and the new code. It prevents channel joins from showing as successful and presence lists from rendering.

[silverbucket]

Good catch. Root cause: in a previous commit I removed the join dispatch from handleJobCompleted based on a wrong assumption that the per-emit callback on socket.emit('message', joinMsg, cb) was firing and would duplicate work. It doesn't fire for join jobs in the new sockethub API — the completed socket event is the canonical completion signal.

IRC depends on the queryAttendance response to set channel.connected = true and populate the user list (via updateChannelUserList in coms.js). XMPP gets users via individual presence updates as a side effect of joining, so it appeared to work.

Restored in 1fb9450. If both the per-emit callback and the completed event somehow fire, duplicate queryAttendance is harmless (fire-and-forget).

[raucao]

This is just adding back an unrelated handler, which doesn't fix failed parsing for presence messages. The error is still exactly the same.

Please review your LLM's replies and changes before pushing them and then copying text in replies to me. I'm not willing to work like this. Every contributor is responsible for their own contributions, and any generated content must be treated like the contributors themselves wrote all of it.

[silverbucket]

@raucao I understand, and I am sorry. I did not ask the LLM to respond, but also I verified the proposed commit with the same model (using a review skill, which seems to have had responding baked in), and that was Claude 4.7, which has been hallucinating a huge amount.

I should have been much more skeptical about the fix. And usually have separate models review. I am going through some tooling changes and things got sloppy. I got bit several times yesterday.

I totally understand your feeling about not being able to work like this, I would feel the exact same way, I don't want to be on the receiving end of a fucking LLM firehose. I will try to move slower and keep the tooling more constrained.

[raucao]

Thank you!

[silverbucket]

OK, I tested this with XMPP and IRC and everything seems to be working now. Here's a summary of the issues.

Channel spam fix — handlePresenceUpdate was auto-creating channels for every IRC presence event it didn't recognize it (list of all available IRC channels).

• Fix: ignore presence updates for channels we haven't explicitly joined.

Message listener race — setupListeners() was called after instantiateAccountsAndChannels(), so the incoming message handler wasn't registered yet when connections were being established. Incoming messages arriving in that window were silently lost.

• Fix: set up listeners first.

Missing join/leave handlers — handleSockethubMessage had no cases for type: 'join' or type: 'leave', so other users joining/leaving channels was silently ignored.

• Fix: route those to the existing user list update methods.

Platform resolution — platformForMessage didn't check the message.platform property that the server reliably sets. Added it as a fallback. (this is still a maybe for the future, not sure if we should bother maintaining a platform prop, as we have it in the context list as a URI, but for now we do).

[silverbucket]

I think this is a long-standing issue, but removing accounts doesn't seem to work. I have to clear localStorage.